On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:> On 26 Nov 2014, at 16:50, Tom Stellard <tom at stellard.net> wrote: > > > > On Wed, Nov 26, 2014 at 10:15:13AM +0000, Daniel Sanders wrote: > ... > > I will try to look at the patches today. I'm going to delay the release a week > > or so, because of all the merge requests I've received, so there is no rush. > > Hi Tom, > > I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) >Hi Dimitry, Can you cc the appropriate code owners to get their approval. It might help to send a separate email per code owner. Thanks, Tom> > Enabling TLS support for PowerPC32: > > http://llvm.org/viewvc/llvm-project?rev=213960&view=rev > > [PowerPC] Support TLS on PPC32/ELF > > Patch by Justin Hibbits! > > > Two changes needed for being able to link lldb 3.5.x against llvm 3.5.x: > > http://llvm.org/viewvc/llvm-project?rev=215352&view=rev > > AArch64: add support for dynamic-loader relocations > > LLD needs them, and it's good to be able to print them properly when > our object dumpers encounter them. > > Patch by Daniel Stewart. > > http://llvm.org/viewvc/llvm-project?rev=216571&view=rev > > Fix some semantic usability issues with DynamicLibrary. > > This patch allows invalid DynamicLibrary instances to be > constructed, and fixes the const-correctness of the isValid() > method. > > > Fixing a possible SIGILL problem on ARMv6 and lower, plus test: > > http://llvm.org/viewvc/llvm-project?rev=216989&view=rev > > Only emit movw on ARMv6T2+ > > Fix PR18364. > > Patch by Dimitry Andric. > > http://llvm.org/viewvc/llvm-project?rev=216990&view=rev > > Missing test from r216989 > > > Fix assigning garbage to floats in some cases: > > http://llvm.org/viewvc/llvm-project?rev=217410&view=rev > > Set trunc store action to Expand for all X86 targets. > > When compiling without SSE2, isTruncStoreLegal(F64, F32) would return Legal, whereas with SSE2 it would return Expand. And since the Target doesn't seem to actually handle a truncstore for double -> float, it would just output a store of a full double in the space for a float hence overwriting other bits on the stack. > > Patch by Luqman Aden! > > > Enabling armv6k for FreeBSD/ARM: > > http://llvm.org/viewvc/llvm-project?rev=217454&view=rev > > Use armv6k default for FreeBSD/ARM > > Patch by Andrew Turner. > > > Downgrading a DWARF2 section error when .note sections are added to a .S file while debug info is on: > > http://llvm.org/viewvc/llvm-project?rev=218241&view=rev > > Downgrade DWARF2 section limit error to a warning > > We currently emit an error when trying to assemble a file with more > than one section using DWARF2 debug info. This should be a warning > instead, as the resulting file will still be usable, but with a > degraded debug illusion. > > > Fixing a very bad OOM condition when compiling certain programs with debug info on, plus test: > > http://llvm.org/viewvc/llvm-project?rev=221709&view=rev > > Totally forget deallocated SDNodes in SDDbgInfo. > > What would happen before that commit is that the SDDbgValues associated with > a deallocated SDNode would be marked Invalidated, but SDDbgInfo would keep > a map entry keyed by the SDNode pointer pointing to this list of invalidated > SDDbgNodes. As the memory gets reused, the list might get wrongly associated > with another new SDNode. As the SDDbgValues are cloned when they are transfered, > this can lead to an exponential number of SDDbgValues being produced during > DAGCombine like in http://llvm.org/bugs/show_bug.cgi?id=20893 > > Note that the previous behavior wasn't really buggy as the invalidation made > sure that the SDDbgValues won't be used. This commit can be considered a > memory optimization and as such is really hard to validate in a unit-test. > > http://llvm.org/viewvc/llvm-project?rev=221854&view=rev > > Add an assert and a test that verify r221709's fix. > > > Enable AArch64 support for FreeBSD: > > http://llvm.org/viewvc/llvm-project?rev=221900&view=rev > > Hook up FreeBSD AArch64 support > > Patch from Andrew Turner. > > > Partially fix FreeBSD boot2 size optimization regressions: > > http://llvm.org/viewvc/llvm-project?rev=222562&view=rev > > Disable header duplication at -Oz in loop-rotate pass. > > > -Dimitry >
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> > On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Hal, Can you please approve the following revision for backporting to 3.5.1: r213960: [PowerPC] Support TLS on PPC32/ELF -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/c3a01963/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Tim, Can you please approve the following revisions for backporting to 3.5.1: Two changes needed for being able to link lldb 3.5.x against llvm 3.5.x: r215352: AArch64: add support for dynamic-loader relocations r216571: Fix some semantic usability issues with DynamicLibrary. -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/fd4c5d34/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Renato, Can you please approve the following revisions for backporting to 3.5.1: r216989: Only emit movw on ARMv6T2+ r216990: Missing test from r216989 -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/5c6872b4/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Nadav and Bob, Can you please approve the following revision for backporting to 3.5.1: Fix assigning garbage to floats in some cases: r217410: Set trunc store action to Expand for all X86 targets. -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/9c455a62/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Chad, Can you please approve the following revisions for backporting to 3.5.1: r217454: Use armv6k default for FreeBSD/ARM r221900: Hook up FreeBSD AArch64 support -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/d4b39be7/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Eric and Ben, Can you please approve the following revisions for backporting to 3.5.1: r218241: Downgrade DWARF2 section limit error to a warning r221709: Totally forget deallocated SDNodes in SDDbgInfo. r221854: Add an assert and a test that verify r221709's fix. -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/7d133761/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi Rafael and Hans, Can you please approve the following revision for backporting to 3.5.1: Partially fix FreeBSD boot2 size optimization regressions: r222562: Disable header duplication at -Oz in loop-rotate pass. -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/bbe41a47/attachment.sig>
On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote:> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote:...>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :)...> Can you cc the appropriate code owners to get their approval. It might > help to send a separate email per code owner.Hi David, Can you please approve the following revision for backporting to 3.5.1: r222856: Revert "Added inst combine transforms for single bit tests from Chris's note" -Dimitry -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 194 bytes Desc: Message signed with OpenPGP using GPGMail URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/788ba5bb/attachment.sig>
I have already asked to have that revert approved in another thread. InstCombine has no code owner which means Chris is the de facto owner. On Saturday, November 29, 2014, Dimitry Andric <dimitry at andric.com> wrote:> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net <javascript:;>> > wrote: > > On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... > >> I would like to propose the following additional patches for 3.5.1. > These will already be part of the upcoming clang 3.5.0 import into the > FreeBSD 11.0 base system. Apologies in advance for the long list. :) > ... > > Can you cc the appropriate code owners to get their approval. It might > > help to send a separate email per code owner. > > Hi David, > > Can you please approve the following revision for backporting to 3.5.1: > > r222856: Revert "Added inst combine transforms for single bit tests from > Chris's note" > > -Dimitry > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141129/049c2d52/attachment.html>
> On Nov 29, 2014, at 9:34 PM, Dimitry Andric <dimitry at andric.com> wrote: > > On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: >> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... >>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > ... >> Can you cc the appropriate code owners to get their approval. It might >> help to send a separate email per code owner. > > Hi Nadav and Bob, > > Can you please approve the following revision for backporting to 3.5.1: > > Fix assigning garbage to floats in some cases: > r217410: Set trunc store action to Expand for all X86 targets.r217410 looks good and should be included in 3.5.1. Thanks, Nadav> > -Dimitry >
On 29 November 2014 at 14:34, Dimitry Andric <dimitry at andric.com> wrote:> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: >> On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... >>> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > ... >> Can you cc the appropriate code owners to get their approval. It might >> help to send a separate email per code owner. > > Hi Rafael and Hans, > > Can you please approve the following revision for backporting to 3.5.1: > > Partially fix FreeBSD boot2 size optimization regressions: > r222562: Disable header duplication at -Oz in loop-rotate pass.It seems safe, but I am not an expert in the area. And it would have been really nice to have a test for r222562 :-( Cheers, Rafael
On 29 November 2014 at 19:34, Dimitry Andric <dimitry at andric.com> wrote:> r216989: Only emit movw on ARMv6T2+ > r216990: Missing test from r216989Hi Dimitry, These are bug fixes and should be ok. cheers, --renato
Hi Dimitry,> Two changes needed for being able to link lldb 3.5.x against llvm 3.5.x: > r215352: AArch64: add support for dynamic-loader relocations > r216571: Fix some semantic usability issues with DynamicLibrary.The first one is probably OK (an ABI of pure evil might break, but I'm not aware of any real world examples). But the second looks like it's an ABI change, which I thought were forbidden even at the C++ level for point releases. Cheers. Tim.
On Sat, Nov 29, 2014 at 08:34:34PM +0100, Dimitry Andric wrote:> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: > > On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... > >> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > ... > > Can you cc the appropriate code owners to get their approval. It might > > help to send a separate email per code owner. > > Hi Renato, > > Can you please approve the following revisions for backporting to 3.5.1: > > r216989: Only emit movw on ARMv6T2+ > r216990: Missing test from r216989 >These both LGTM, go ahead and merge into the 3.5 branch. -Tom> -Dimitry >
Tom Stellard
2014-Dec-05 20:15 UTC
[LLVMdev] ARM/AArch64 FreeBSD patches for 3.5.1 (was Re: Proposed patches for Clang 3.5.1)
On Sat, Nov 29, 2014 at 08:34:37PM +0100, Dimitry Andric wrote:> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: > > On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... > >> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > ... > > Can you cc the appropriate code owners to get their approval. It might > > help to send a separate email per code owner. > > Hi Chad, > > Can you please approve the following revisions for backporting to 3.5.1: > > r217454: Use armv6k default for FreeBSD/ARM > r221900: Hook up FreeBSD AArch64 support >cc'ing ARM an AArch64 code owners Links to the patches: http://llvm.org/viewvc/llvm-project?view=revision&revision=217454 http://llvm.org/viewvc/llvm-project?view=revision&revision=221900 I only see Chad listed as code owner for fast-isel, I'm not sure why he would need to approve these patches. Is there a FreeBSD code owner? These patches seem to only affect FreeBSD and are fairly trivial. As long as Tim and Evan don't have any objections I think these can be merged. -Tom
On Sat, Nov 29, 2014 at 08:34:32PM +0100, Dimitry Andric wrote:> On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: > > On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... > >> I would like to propose the following additional patches for 3.5.1. These will already be part of the upcoming clang 3.5.0 import into the FreeBSD 11.0 base system. Apologies in advance for the long list. :) > ... > > Can you cc the appropriate code owners to get their approval. It might > > help to send a separate email per code owner. > > Hi Tim, > > Can you please approve the following revisions for backporting to 3.5.1: > > Two changes needed for being able to link lldb 3.5.x against llvm 3.5.x: > r215352: AArch64: add support for dynamic-loader relocationsTim approved, so go ahead and merge this one.> r216571: Fix some semantic usability issues with DynamicLibrary. >This does change the ABI as Tim pointed out, so we can't accepted it. -Tom> -Dimitry >
----- Original Message -----> From: "Dimitry Andric" <dimitry at andric.com> > To: "Hal Finkel" <hfinkel at anl.gov> > Cc: "LLVM Developers Mailing List (llvmdev at cs.uiuc.edu)" <llvmdev at cs.uiuc.edu>, "Tom Stellard" <tom at stellard.net> > Sent: Saturday, November 29, 2014 1:34:21 PM > Subject: Re: [LLVMdev] Proposed patches for Clang 3.5.1 > > On 29 Nov 2014, at 02:48, Tom Stellard <tom at stellard.net> wrote: > > > > On Wed, Nov 26, 2014 at 07:44:20PM +0100, Dimitry Andric wrote: > ... > >> I would like to propose the following additional patches for > >> 3.5.1. These will already be part of the upcoming clang 3.5.0 > >> import into the FreeBSD 11.0 base system. Apologies in advance > >> for the long list. :) > ... > > Can you cc the appropriate code owners to get their approval. It > > might > > help to send a separate email per code owner. > > Hi Hal, > > Can you please approve the following revision for backporting to > 3.5.1: > > r213960: [PowerPC] Support TLS on PPC32/ELFOkay; I don't think this has caused any issues after it landed, so I approve back-porting it. This is just on the edge of what I'd consider eligible for a dot release, technically being a new feature, but it does fix assert-on-valid bugs, so there is also bug-fixing value in taking it. -Hal> > -Dimitry > >-- Hal Finkel Assistant Computational Scientist Leadership Computing Facility Argonne National Laboratory