On Oct 5, 2014, at 9:37 AM, Renato Golin <renato.golin at linaro.org> wrote:> On 5 October 2014 07:19, Saleem Abdulrasool <compnerd at compnerd.org> wrote: >> So with that in mind, I would like to ask, would it be possible to consider >> switching to LLVM style for lld? > > We don't usually enforce code styles on side projects because it > doesn't make sense to do so. There are too many conflicts between > developers, external source code, style-oriented commits that break > the time-line of the project, that it's just not worth worrying about > it. Not to mention that style is fashion, some like it this way, some > like it that way.The only case where this makes sense (that I’m aware of) is libc++, given that it is a very different (and highly constrained) domain. I think that lld and lldb following different coding standards is a serious bug, which increases friction within the community. I’d support progressively moving them to a style more similar to LLVM. -Chris
On 6 October 2014 22:58, Chris Lattner <clattner at apple.com> wrote:> The only case where this makes sense (that I’m aware of) is libc++, given that it is a very different (and highly constrained) domain. I think that lld and lldb following different coding standards is a serious bug, which increases friction within the community.That seems to be the general feeling, yes.> I’d support progressively moving them to a style more similar to LLVM.What I suggested on my second paragraph. :) I personally think that complete code refactoring is a bit pointless. Then again, this is a decision to lld developers, I think. cheers, --renato
On Mon, Oct 6, 2014 at 3:41 PM, Renato Golin <renato.golin at linaro.org> wrote:> On 6 October 2014 22:58, Chris Lattner <clattner at apple.com> wrote: > > The only case where this makes sense (that I’m aware of) is libc++, > given that it is a very different (and highly constrained) domain. I think > that lld and lldb following different coding standards is a serious bug, > which increases friction within the community. > > That seems to be the general feeling, yes. > > > > I’d support progressively moving them to a style more similar to LLVM. > > What I suggested on my second paragraph. :) > > I personally think that complete code refactoring is a bit pointless. > Then again, this is a decision to lld developers, I think. >Well, this may be my personal preference, but I don't like to keep the old code in old style. Old code would be there untouched for years. LLD is fortunately not a large project so it shouldn't be hard to convert it entirely in one patch.> cheers, > --renato > > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141006/2dee3fb8/attachment.html>