On 18 May 2013 19:29, David Tweed <David.Tweed at arm.com> wrote:> Regarding solving PR16013 that looks like a relatively tractable job (on > both 32-bit arm and aarch64) IF you're already familiar with the > implications of what the instruction set does; unfortunately that set > doesn't include me... >Hi David, I'll move all remote tests to a dir and mark them unsupported for now. What about the ExecutionEngine unittest below? Can you fix it? Or disable it on ARM? http://lab.llvm.org:8011/builders/llvm-armv5-linux/builds/298/steps/test-llvm/logs/LLVM-Unit%20%3A%3A%20ExecutionEngine__MCJIT____wd__buildbot__llvm-armv5-linux__llvm__unittests__ExecutionEngine__MCJIT__Debug%2BAsserts__MCJITTests__MCJITTest.return_global cheers, --renato -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130518/3e5506b9/attachment.html>
> I'll move all remote tests to a dir and mark them unsupported for now. What > about the ExecutionEngine unittest below? Can you fix it? Or disable it on > ARM?If I read your summary correctly it's only failing armv5. I wouldn't want to stop testing it on everything else because of an ancient box like that. Cheers. Tim
On 18 May 2013 19:51, Tim Northover <t.p.northover at gmail.com> wrote:> If I read your summary correctly it's only failing armv5. I wouldn't >want to stop testing it on everything else because of an ancient box> like that. >Well, if we don't care about ARMv5, then, please let's turn that bot off. We either have a bot green or none at all. We can selectively disable LIT tests on "armv5" or "armv7" and I've done so before because it was clear that ARMv5 would never support things like the old JIT. The bot is green, and if there isn't a very strong reason against it, I'd like it to remain green. Disabling an unimplemented feature on that hardware seems like the correct thing to do, to me. Since that's a unit-test, you probably have access to the target triple and it should be trivial to disable it on "armv5", maybe even *all* JIT tests, since we'll never implement it for that architecture anyway. Either that, or let's turn the bot off for good. cheers, --renato -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20130518/ea72b233/attachment.html>