Anshuman Dasgupta
2012-Dec-11 15:26 UTC
[LLVMdev] Possible bug in DFAPacketizer::ReadTable
Great! Can you please check in that test case or better still, a reduced version of that test. Thanks -Anshu --- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation On 12/11/2012 5:47 AM, Carlos Sánchez de La Lama wrote:> Hi again, > > I can confirm r169783 fixes the problem. My testbench segfaulted in > r169782 but works after your commit. > > We can close the issue. > > Thanks, > > Carlos > > > 2012/12/11 Carlos Sánchez de La Lama <csanchezdll at gmail.com > <mailto:csanchezdll at gmail.com>> > > Hi Anshu, > > I got a testbench which fails (and segfaults) consistently with an > environment (gcc + os) conveniently preserved in a virtual > machine. I will confirm that it is gone there and report. > > Thanks for the fix :) > > > Carlos >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121211/5cb673b8/attachment.html>
Carlos Sánchez de La Lama
2012-Dec-13 07:53 UTC
[LLVMdev] Possible bug in DFAPacketizer::ReadTable
Hi Anshu, the "test case" I referred to requires the compilation of our whole back-end. It segdaults when using gcc-4.4.3 under Ubuntu 10.04, with other combinations I have tested it still happens (before your patch) but is not noticeable unless using gdb. I have tried making valgrind catch it but no success... so I guess the only way to *see* it is using the debugger. I remember seeing it happen (though not segfault) on Hexagon as well but now I seem unable to reproduce it :S BR Carlos 2012/12/11 Anshuman Dasgupta <adasgupt at codeaurora.org>> Great! Can you please check in that test case or better still, a reduced > version of that test. > > > Thanks > -Anshu > > --- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted > by The Linux Foundation > > On 12/11/2012 5:47 AM, Carlos Sánchez de La Lama wrote: > > Hi again, > > I can confirm r169783 fixes the problem. My testbench segfaulted in > r169782 but works after your commit. > > We can close the issue. > > Thanks, > > Carlos > > > 2012/12/11 Carlos Sánchez de La Lama <csanchezdll at gmail.com> > >> Hi Anshu, >> >> I got a testbench which fails (and segfaults) consistently with an >> environment (gcc + os) conveniently preserved in a virtual machine. I will >> confirm that it is gone there and report. >> >> Thanks for the fix :) >> >> >> Carlos >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121213/48910cf7/attachment.html>
Anshuman Dasgupta
2012-Dec-13 15:43 UTC
[LLVMdev] Possible bug in DFAPacketizer::ReadTable
I see. I couldn't reproduce the invalid read on Hexagon either. I'll try to reverse engineer a test case. Not having test coverage for a potential segfault makes me extremely wary. Thanks -Anshu --- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation On 12/13/2012 1:53 AM, Carlos Sánchez de La Lama wrote:> Hi Anshu, > > the "test case" I referred to requires the compilation of our whole > back-end. It segdaults when using gcc-4.4.3 under Ubuntu 10.04, with > other combinations I have tested it still happens (before your patch) > but is not noticeable unless using gdb. I have tried making valgrind > catch it but no success... so I guess the only way to *see* it is > using the debugger. > > I remember seeing it happen (though not segfault) on Hexagon as well > but now I seem unable to reproduce it :S > > BR > > Carlos > > > 2012/12/11 Anshuman Dasgupta <adasgupt at codeaurora.org > <mailto:adasgupt at codeaurora.org>> > > Great! Can you please check in that test case or better still, a > reduced version of that test. > > > Thanks > -Anshu > > --- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > hosted by The Linux Foundation > > On 12/11/2012 5:47 AM, Carlos Sánchez de La Lama wrote: >> Hi again, >> >> I can confirm r169783 fixes the problem. My testbench segfaulted >> in r169782 but works after your commit. >> >> We can close the issue. >> >> Thanks, >> >> Carlos >> >> >> 2012/12/11 Carlos Sánchez de La Lama <csanchezdll at gmail.com >> <mailto:csanchezdll at gmail.com>> >> >> Hi Anshu, >> >> I got a testbench which fails (and segfaults) consistently >> with an environment (gcc + os) conveniently preserved in a >> virtual machine. I will confirm that it is gone there and report. >> >> Thanks for the fix :) >> >> >> Carlos >> >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20121213/90df0d42/attachment.html>