Eli, When you say "include tests" what exactly do you mean - ability to run newly produced binary on newly supported target? Can you please elaborate? Thanks. Sergei Larin -----Original Message----- From: llvmdev-bounces at cs.uiuc.edu [mailto:llvmdev-bounces at cs.uiuc.edu] On Behalf Of Eli Friedman Sent: Tuesday, November 01, 2011 1:58 PM To: Tony Linthicum Cc: llvmdev at cs.uiuc.edu Subject: Re: [LLVMdev] Contributing new backend to LLVM On Tue, Nov 1, 2011 at 11:44 AM, Tony Linthicum <tlinth at codeaurora.org> wrote:> Hello all, > > We would like to contribute a new backend for Qualcomm's Hexagon > processor. We will actively maintain the port once it is accepted. > Hexagon is a VLIW core that is used principally in modem and low power > audio applications in Qualcomm's chip sets. > > We have a patch for both llvm and for clang. As this is a new port, > these patches are quite large (approximately 26k and 3k lines, > respectively). Most of the patches consist of, quite naturally, new > files. I have looked for guidelines for submitting a new backend, but > have not found anything. Is there anything of that nature? If not, my > plan is to simply submit the two patches. Any other suggestions?There isn't any special prodedure for submitting new backends... standard patch review guidelines apply. Make sure you include tests. -Eli _______________________________________________ LLVM Developers mailing list LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
On Tue, Nov 1, 2011 at 12:01 PM, Sergei Larin <slarin at codeaurora.org> wrote:> Eli, > > When you say "include tests" what exactly do you mean - ability to run > newly produced binary on newly supported target? > Can you please elaborate?Well, it would be nice to know that it can produce working binaries, but no, you don't need to provide tests like that. Just make sure there are tests in test/CodeGen/ to check that the backend generates the expected assembly code for simple cases. -Eli
Eli, We can probably think of something like that, but diff on assembly output is prone to false negatives and depends on the machine independent part of the compiler... Maybe someone can suggest more elegant way to verify the basic functionality? Thanks. Sergei Larin -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum. -----Original Message----- From: Eli Friedman [mailto:eli.friedman at gmail.com] Sent: Tuesday, November 01, 2011 2:12 PM To: Sergei Larin Cc: Tony Linthicum; llvmdev at cs.uiuc.edu Subject: Re: [LLVMdev] Contributing new backend to LLVM On Tue, Nov 1, 2011 at 12:01 PM, Sergei Larin <slarin at codeaurora.org> wrote:> Eli, > > When you say "include tests" what exactly do you mean - ability to run > newly produced binary on newly supported target? > Can you please elaborate?Well, it would be nice to know that it can produce working binaries, but no, you don't need to provide tests like that. Just make sure there are tests in test/CodeGen/ to check that the backend generates the expected assembly code for simple cases. -Eli