llvm dev - Oct 2011 - [LLVMdev] Make update and svn 1.7

Due to a change in the "svn info" output, the "make update"
command has some issue with svn 1.7

With svn 1.7, the svn info command outputs an additional line for the working
copy root path like this one:
----
…
Path: /Projects/llvm
Working Copy Root Path: /Projects/llvm
…
----

As the "make update" command look for the "Path:" pattern in
the output, it now found 2 lines, and try to invoke "svn update Copy"
for each subproject (as Copy is the second word on the 'Working Copy Root
path:' line).

I attached a patch to fix this issue by looking only for lines that start by
"Path:" and not for all lines that contains "Path:"

-- Jean-Daniel



-------------- next part --------------
A non-text attachment was scrubbed...
Name: svn17.patch
Type: application/octet-stream
Size: 417 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20111019/0843e38d/attachment.obj>

Looks good to me, committed as r142535. I don't actually have svn 1.7
to verify the behavior you describe, but the patch seems like the
right thing to do anyway to be more precise about what we're matching.

- David

On Wed, Oct 19, 2011 at 3:19 AM, Jean-Daniel Dupas
<devlists at shadowlab.org> wrote:
> Due to a change in the "svn info" output, the "make
update" command has some issue with svn 1.7
>
> With svn 1.7, the svn info command outputs an additional line for the
working copy root path like this one:
> ----
> …
> Path: /Projects/llvm
> Working Copy Root Path: /Projects/llvm
> …
> ----
>
> As the "make update" command look for the "Path:"
pattern in the output, it now found 2 lines, and try to invoke "svn update
Copy" for each subproject (as Copy is the second word on the 'Working
Copy Root path:' line).
>
> I attached a patch to fix this issue by looking only for lines that start
by "Path:" and not for all lines that contains "Path:"
>
> -- Jean-Daniel
>
>
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>