Koan-Sin Tan
2011-May-13 11:16 UTC
[LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
Renato, The result of running 'llvm-lit $LLVM/TEST/MC" is: Expected Passes : 330 Expected Failures : 20 Actually it passed "make check", no unexpected result. On Fri, May 13, 2011 at 5:14 PM, Renato Golin <renato.golin at arm.com> wrote:> On 13 May 2011 06:42, Koan-Sin Tan <koansin.tan at gmail.com> wrote: >> With that attached patch, we can compile and run some (not all) Android >> NDK samples without problem. > > Hi Koan, > > Have you tried to run Intel and other platform tests? > > I feel uncomfortable with so many changes in generic MC/ELF regarding > specific ARM support... not to mention the magic variables on > shifts... ;) > > cheers, > --renato >-- // koan-sin tan
Renato Golin
2011-May-13 12:15 UTC
[LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
On 13 May 2011 12:16, Koan-Sin Tan <koansin.tan at gmail.com> wrote:> The result of running 'llvm-lit $LLVM/TEST/MC" is: > Expected Passes : 330 > Expected Failures : 20 > Actually it passed "make check", no unexpected result.Try make check-all, it runs more tests... Still, I think someone more in line with MC/ELF should have a look at the patch. Rafael? Jason? cheers, --renato
Rafael Avila de Espindola
2011-May-13 14:02 UTC
[LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
On 11-05-13 08:15 AM, Renato Golin wrote:> On 13 May 2011 12:16, Koan-Sin Tan<koansin.tan at gmail.com> wrote: >> The result of running 'llvm-lit $LLVM/TEST/MC" is: >> Expected Passes : 330 >> Expected Failures : 20 >> Actually it passed "make check", no unexpected result. > > Try make check-all, it runs more tests... > > Still, I think someone more in line with MC/ELF should have a look at > the patch. Rafael? Jason?When we first started adding arm we decided to make it work first and refactor it afterwards since none of us was sure how much sharing there could be. Given that, it is inevitable that some changes will be to the common code for now. The patch doesn't violate any of the designs decisions of MC, so I am OK with it if you add a test. Ideally it should be a .s -> .o test, but if you need to test something that is not yet handled by the ARM parser, then it is ok to have a .ll -> .o test, but add a FIXME to it.> cheers, > --renatoCheers, Rafael
Seemingly Similar Threads
- [LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
- [LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
- [LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
- [LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly
- [LLVMdev] [Patch] Let MC/ELF generate Thumb/Thumb-2 are properly