Attached is a patch that renames ISD::BIT_CONVERT to ISD::BITCAST as per http://www.llvm.org/OpenProjects.html, #3 under Code Generator Improvements. I have not updated the OpenProjects.html file itself as I could not find that file in the source code. The patch itself also includes elimination of whitespace at the end of lines because my VIM settings do that automatically. If this is not desired then I can rework the patch without this. -- Wesley Peck University of Kansas SLDG Laboratory -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101121/27c6e462/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: bitconvert_bitcast.patch.gz Type: application/x-gzip Size: 72706 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101121/27c6e462/attachment.bin> -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101121/27c6e462/attachment-0001.html>
On Nov 21, 2010, at 7:10 PM, Wesley Peck wrote:> Attached is a patch that renames ISD::BIT_CONVERT to ISD::BITCAST as per http://www.llvm.org/OpenProjects.html, #3 under Code Generator Improvements. I have not updated the OpenProjects.html file itself as I could not find that file in the source code. > > The patch itself also includes elimination of whitespace at the end of lines because my VIM settings do that automatically. If this is not desired then I can rework the patch without this.Ok! Please commit it. The one thing to watch for is to make sure that indentation etc all look ok after the change since BITCAST is shorter than BIT_CONVERT. OpenProjects.html is in the llvm-www svn module, let me know and I can update it for you if you prefer. -Chris -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101122/b7e01ac9/attachment.html>
On Nov 22, 2010, at 8:30 PM, Chris Lattner wrote:> Ok! Please commit it. The one thing to watch for is to make sure that indentation etc all look ok after the change since BITCAST is shorter than BIT_CONVERT. OpenProjects.html is in the llvm-www svn module, let me know and I can update it for you if you prefer.Committed in 119990 and 119991. Thanks for reviewing the patch. -- Wesley Peck University of Kansas SLDG Laboratory -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101122/079857b0/attachment.html>