Zhanyong Wan (λx.x x)
2010-Nov-16 01:11 UTC
[LLVMdev] cosmetic changes to LLVM coding standards
Hi Chris, I was reading the LLVM coding standards and noticed some typos & formatting nits. Please see http://codereview.appspot.com/3127041 for my proposed fix. Most of changes are local and cosmetic. The only bigger change I made is to group the sections about iostream and raw_ostream together, as they are logically related. I had to edit the text a little bit after the move, in order to reduce the repetition. The patch is also attached to this message. Would you please take a look? Thanks! -- Zhanyong -------------- next part -------------- A non-text attachment was scrubbed... Name: coding-standards.patch Type: text/x-patch Size: 11699 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20101115/9ab62536/attachment.bin>
On Nov 15, 2010, at 5:11 PM, Zhanyong Wan (λx.x x) wrote:> Hi Chris, > > I was reading the LLVM coding standards and noticed some typos & > formatting nits. Please see http://codereview.appspot.com/3127041 for > my proposed fix. > > Most of changes are local and cosmetic. The only bigger change I made > is to group the sections about iostream and raw_ostream together, as > they are logically related. I had to edit the text a little bit after > the move, in order to reduce the repetition.Looks great! Applied in r119515, thanks! -Chris
Possibly Parallel Threads
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] draft rule for naming types/functions/variables
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables
- [LLVMdev] [cfe-dev] draft rule for naming types/functions/variables