Nick Lewycky
2009-Sep-05 20:53 UTC
[LLVMdev] should we stop using llvm-as/llvm-dis in tests?
A recent commit added the ability to opt and llc to read .ll files directly. Should we go through and update the existing tests? llvm-as < %s | opt ... | llvm-dis would become: opt %s ... -print-module and llvm-as < %s | llc would become: llc < %s The pro of this is that it would remove the bitcode write and read from the tests, making them faster. The con of this is that it would remove the bitcode write and read from the tests, making them less well tested. Should we not make this change at all? Should we create some sort of 'exhaustive bitcode tests' first, and require that new language features are added there? Or should we just do it and create "llvm-as < %s | llvm-dis" tests under test/Bitcode as problems are found? Also, has anyone else already started doing this? Nick
Chris Lattner
2009-Sep-06 00:51 UTC
[LLVMdev] should we stop using llvm-as/llvm-dis in tests?
On Sep 5, 2009, at 1:53 PM, Nick Lewycky wrote:> A recent commit added the ability to opt and llc to read .ll files > directly. Should we go through and update the existing tests?Yes, I think that Dan is planning to do this. -Chris> > llvm-as < %s | opt ... | llvm-dis > > would become: > > opt %s ... -print-module > > and > > llvm-as < %s | llc > > would become: > > llc < %s > > The pro of this is that it would remove the bitcode write and read > from > the tests, making them faster. The con of this is that it would remove > the bitcode write and read from the tests, making them less well > tested. > > Should we not make this change at all? Should we create some sort of > 'exhaustive bitcode tests' first, and require that new language > features > are added there? Or should we just do it and create "llvm-as < %s | > llvm-dis" tests under test/Bitcode as problems are found? > > Also, has anyone else already started doing this? > > Nick > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
Daniel Dunbar
2009-Sep-06 01:40 UTC
[LLVMdev] should we stop using llvm-as/llvm-dis in tests?
On Sat, Sep 5, 2009 at 5:51 PM, Chris Lattner<clattner at apple.com> wrote:> > On Sep 5, 2009, at 1:53 PM, Nick Lewycky wrote: > >> A recent commit added the ability to opt and llc to read .ll files >> directly. Should we go through and update the existing tests? > > Yes, I think that Dan is planning to do this.... and it is definitely worth doing. On my system a 'time' of make check reports that about 50% of the real time running make check is spent in the OS. This probably also limits the efficacy of attempts to parallelize the test suite, if someone was crazy enough to do that. Using opt -S for tests that end up going to llvm-dis would also be nice. - Daniel