Patrick Boettcher
2009-Jan-20 09:44 UTC
[LLVMdev] [PATCH] correct argument order of gv when viewgraph is called
Hi list, On my system I have gv 3.5.8 and it does not like to be called with --spartan before the <filename>. The man-page is stating that the file name has to come before all arguments and the --spartan is actually -spartan. I don't know for newer versions of gv. The attached patch fixes that for me. Please apply if appropriate. thanks, Patrick. -------------- next part -------------- Index: lib/Support/GraphWriter.cpp ==================================================================--- lib/Support/GraphWriter.cpp (revision 62576) +++ lib/Support/GraphWriter.cpp (working copy) @@ -57,8 +57,8 @@ sys::Path gv(LLVM_PATH_GV); args.clear(); args.push_back(gv.c_str()); - args.push_back("--spartan"); args.push_back(PSFilename.c_str()); + args.push_back("-spartan"); args.push_back(0); ErrMsg.clear();
Chris Lattner
2009-Jan-20 18:25 UTC
[LLVMdev] [PATCH] correct argument order of gv when viewgraph is called
On Jan 20, 2009, at 1:44 AM, Patrick Boettcher wrote:> Hi list, > > On my system I have gv 3.5.8 and it does not like to be called with > --spartan before the <filename>. > > The man-page is stating that the file name has to come before all > arguments and the --spartan is actually -spartan. I don't know for > newer versions of gv.Applied, thanks! http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20090119/072408.html -Chris