Folks, It appears the Windows build has regressed over the past week. The build fails quite early (during the "Performing TableGenStep" phase). Any help/pointers would be appreciated. Thanks, snaroff (a clang developer)
steve naroff <snaroff at apple.com> writes:> Folks, > > It appears the Windows build has regressed over the past week. > > The build fails quite early (during the "Performing TableGenStep" > phase). > > Any help/pointers would be appreciated.It breaks for me because the usage of INT64_C, which was introduced on r57663 and 57668. Some googling around indicates that, on Windows, one should #define INT64_C(val) val##i64 It is present on TableGen/DAGISelEmitter.cpp and TableGen/Record.cpp. -- Oscar
Óscar Fuentes <ofv at wanadoo.es> writes:>> It appears the Windows build has regressed over the past week. >> >> The build fails quite early (during the "Performing TableGenStep" >> phase). >> >> Any help/pointers would be appreciated. > > It breaks for me because the usage of INT64_C, which was introduced on > r57663 and 57668. > > Some googling around indicates that, on Windows, one shouldr/Windows/MSVC++ This patch brings the build fordward: Index: utils/TableGen/Record.cpp ==================================================================--- utils/TableGen/Record.cpp (revision 58037) +++ utils/TableGen/Record.cpp (working copy) @@ -15,6 +15,7 @@ #include "llvm/Support/DataTypes.h" #include "llvm/Support/Streams.h" #include "llvm/ADT/StringExtras.h" +#include "llvm/Config/config.h" #include <ios> using namespace llvm; Index: win32/config.h ==================================================================--- win32/config.h (revision 58037) +++ win32/config.h (working copy) @@ -27,3 +27,4 @@ #define stricmp _stricmp #define strdup _strdup +#define INT64_C(val) val##i64
Oops, I had fixed the "DataTypes.h" copy instead of the versioned "DataTypes.h.in" and missed the commit, sorry about that. -Argiris Óscar Fuentes wrote:> steve naroff <snaroff at apple.com> writes: > > >> Folks, >> >> It appears the Windows build has regressed over the past week. >> >> The build fails quite early (during the "Performing TableGenStep" >> phase). >> >> Any help/pointers would be appreciated. >> > > It breaks for me because the usage of INT64_C, which was introduced on > r57663 and 57668. > > Some googling around indicates that, on Windows, one should > > #define INT64_C(val) val##i64 > > It is present on TableGen/DAGISelEmitter.cpp and TableGen/Record.cpp. > >
Óscar Fuentes wrote:> steve naroff <snaroff at apple.com> writes: > > >> Folks, >> >> It appears the Windows build has regressed over the past week. >> >> The build fails quite early (during the "Performing TableGenStep" >> phase). >> >> Any help/pointers would be appreciated. >> > > It breaks for me because the usage of INT64_C, which was introduced on > r57663 and 57668. > > Some googling around indicates that, on Windows, one should > > #define INT64_C(val) val##i64 >On MSVC. MingW32 provides this macro in stdint.h. Kenneth