So, a while back I got a compile error where the assembly was missing some whitespace between a .set and the identifier and tracked it down to this simple mistake that I just verified is still in the tree: Index: lib/Target/ARM/ARMTargetAsmInfo.cpp ==================================================================--- lib/Target/ARM/ARMTargetAsmInfo.cpp (revision 48700) +++ lib/Target/ARM/ARMTargetAsmInfo.cpp (working copy) @@ -49,7 +49,7 @@ PrivateGlobalPrefix = "L"; BSSSection = 0; // no BSS section. ZeroFillDirective = "\t.zerofill\t"; // Uses .zerofill - SetDirective = "\t.set"; + SetDirective = "\t.set\t"; WeakRefDirective = "\t.weak_reference\t"; HiddenDirective = "\t.private_extern\t"; ProtectedDirective = NULL; I unfortunately don't have the code that died anymore (it was a couple months ago, and I'm unfortunately just now getting on this mailing list to report the issue), but it seems pretty obvious from the surrounding context to be wrong, and there's even another initialization of SetDirective in the same file that _does_ have the traililng \t. Sincerely, Jay Freeman (saurik) saurik at saurik.com http://www.saurik.com/ -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080323/1f9b86f0/attachment.html>
Committed. Thanks! Evan On Mar 23, 2008, at 4:39 AM, Jay Freeman (saurik) wrote:> So, a while back I got a compile error where the assembly was > missing some whitespace between a .set and the identifier and > tracked it down to this simple mistake that I just verified is still > in the tree: > > Index: lib/Target/ARM/ARMTargetAsmInfo.cpp > ==================================================================> --- lib/Target/ARM/ARMTargetAsmInfo.cpp (revision 48700) > +++ lib/Target/ARM/ARMTargetAsmInfo.cpp (working copy) > @@ -49,7 +49,7 @@ > PrivateGlobalPrefix = "L"; > BSSSection = 0; // no BSS section. > ZeroFillDirective = "\t.zerofill\t"; // Uses .zerofill > - SetDirective = "\t.set"; > + SetDirective = "\t.set\t"; > WeakRefDirective = "\t.weak_reference\t"; > HiddenDirective = "\t.private_extern\t"; > ProtectedDirective = NULL; > I unfortunately don't have the code that died anymore (it was a > couple months ago, and I'm unfortunately just now getting on this > mailing list to report the issue), but it seems pretty obvious from > the surrounding context to be wrong, and there's even another > initialization of SetDirective in the same file that _does_ have the > traililng \t. > > Sincerely, > Jay Freeman (saurik) > saurik at saurik.com > http://www.saurik.com/ > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20080324/fe2832e3/attachment.html>
Reasonably Related Threads
- [LLVMdev] patch for llc/ARM: added mechanism to move switch tables from .text -> .data; also cleanup and documentation
- [LLVMdev] patch for llc/ARM: added mechanism to move switch tables from .text -> .data; also cleanup and documentation
- [LLVMdev] patch for llc/ARM: added mechanism to move switch tables from .text -> .data; also cleanup and documentation
- [LLVMdev] MS C++ gives error C2371 on this code while (obviously)gcc compiles it fine
- [LLVMdev] non-enable-llvm support in llvm-gcc-4.2 issue