Chris Lattner
2005-Apr-10 21:16 UTC
[LLVMdev] sys::Program::ExecuteAndWait() caller problems
On Sun, 10 Apr 2005, Markus F.X.J. Oberhumer wrote:> sys::Program::ExecuteAndWait() requires that the first element in "args" > should be the name of the program, but (at least) llvm-ld.cpp and gccld.cpp > fail to do so, thereby effectively swallowing the first parameter. > This is the reason that -native-cbe has not working for some time - actually > I wonder why no other problems have been caused by this...Ok, yeah this did cause some problems with the ToolRunner.cpp file which I fixed quite a while ago. The problem was introduced due to some refactoring reid did with the program api's. Thanks for pointing this out!> Please revisit all callers of ExecuteAndWait().The only one I'm not sure of is the llvmc usage of it in CompilerDriver.cpp. Reid, when you get a chance, can you verify that it is ok? -Chris -- http://nondot.org/sabre/ http://llvm.cs.uiuc.edu/
Reid Spencer
2005-Apr-11 05:48 UTC
[LLVMdev] sys::Program::ExecuteAndWait() caller problems
Fixed in tools/llvmc/CompilerDriver.cpp Reid. On Sun, 2005-04-10 at 16:16 -0500, Chris Lattner wrote:> On Sun, 10 Apr 2005, Markus F.X.J. Oberhumer wrote: > > sys::Program::ExecuteAndWait() requires that the first element in "args" > > should be the name of the program, but (at least) llvm-ld.cpp and gccld.cpp > > fail to do so, thereby effectively swallowing the first parameter. > > This is the reason that -native-cbe has not working for some time - actually > > I wonder why no other problems have been caused by this... > > Ok, yeah this did cause some problems with the ToolRunner.cpp file which I > fixed quite a while ago. The problem was introduced due to some > refactoring reid did with the program api's. Thanks for pointing this > out! > > > Please revisit all callers of ExecuteAndWait(). > > The only one I'm not sure of is the llvmc usage of it in > CompilerDriver.cpp. Reid, when you get a chance, can you verify that it > is ok? > > -Chris >_______________________ Reid Spencer President & CTO eXtensible Systems, Inc. rspencer at x10sys.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 189 bytes Desc: This is a digitally signed message part URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20050410/3972fdec/attachment.sig>
Seemingly Similar Threads
- [LLVMdev] sys::Program::ExecuteAndWait() caller problems
- [LLVMdev] [PATCH 1/2] Trailing whitespace.
- [LLVMdev] Using ReST for documentation
- [LLVMdev] Programmatic compilation of C++ file into bitcode
- [LLVMdev] Error compiling llvm/clang with clang+libc++ with -std=cxx0x