llvm dev - Sep 2004 - [LLVMdev] Code to be moved to the specific platform in lib/System?

Hi

I'm compiling: llvm/lib/Support/SystemUtils.cpp on MinGW. However, it stops 
complaining about these errors:
--------------------------
C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp: In function `bool
   llvm::isExecutableFile(const std::string&)':
C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:44: error: `getuid'
   undeclared (first use this function)
C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:44: error: (Each
   undeclared identifier is reported only once for each function it appears
   in.)
C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:46: error: `getgid'
   undeclared (first use this function)
C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:47: error: 
`S_IXGRP'
   undeclared (first use this function)
C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:49: error: 
`S_IXOTH'
   undeclared (first use this function)
--------------------------

On mingw the these functions or values aren't declared. However, to me it 
seems that the code in SystemUtils.cpp is specific to a platform. Shouldn't 
this code be moved to the specific platform in lib/System?

Any suggestions?

Henrik

_________________________________________________________________
F� alle de nye og sjove ikoner med MSN Messenger http://messenger.msn.dk/

Henrik,

Most of this file has already been put into lib/System. You should be
able to safely remove the offending code. If you run into places that
use llvm::isExecutableFile, please change them to use the
Path::executable() method. There are also methods for checking the magic
number, etc.

I need to clean up the interface of Path to make it more compliant with
LLVM then find all the SystemUtils.h uses in LLVM and convert them to
use lib/System/Path or lib/System/Program. When that is done, the
lib/Support/SystemUtils.cpp file will go away.

Sorry for the inconvenience but I have to do this work incrementally
because its too much to do as a "big bang".

Thanks,

Reid.

On Sat, 2004-09-25 at 01:17, Henrik Bach wrote:
> Hi
> 
> I'm compiling: llvm/lib/Support/SystemUtils.cpp on MinGW. However, it
stops
> complaining about these errors:
> --------------------------
> C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp: In function `bool
>    llvm::isExecutableFile(const std::string&)':
> C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:44: error:
`getuid'
>    undeclared (first use this function)
> C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:44: error: (Each
>    undeclared identifier is reported only once for each function it appears
>    in.)
> C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:46: error:
`getgid'
>    undeclared (first use this function)
> C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:47: error: 
> `S_IXGRP'
>    undeclared (first use this function)
> C:/MinGW/msys/local/src/llvm/lib/Support/SystemUtils.cpp:49: error: 
> `S_IXOTH'
>    undeclared (first use this function)
> --------------------------
> 
> On mingw the these functions or values aren't declared. However, to me
it
> seems that the code in SystemUtils.cpp is specific to a platform.
Shouldn't
> this code be moved to the specific platform in lib/System?
> 
> Any suggestions?
> 
> Henrik
> 
> _________________________________________________________________
> F alle de nye og sjove ikoner med MSN Messenger http://messenger.msn.dk/
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://mail.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20040925/722c70f9/attachment.sig>