Xuan Zhuo
2023-Aug-15 06:30 UTC
[PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()
Hi, Jason Could you skip this patch? Let we review other patches firstly? Thanks.
Jason Wang
2023-Aug-15 07:50 UTC
[PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()
On Tue, Aug 15, 2023 at 2:32?PM Xuan Zhuo <xuanzhuo at linux.alibaba.com> wrote:> > > Hi, Jason > > Could you skip this patch?I'm fine with either merging or dropping this.> > Let we review other patches firstly?I will be on vacation soon, and won't have time to do this until next week. But I spot two possible "issues": 1) the DMA metadata were stored in the headroom of the page, this breaks frags coalescing, we need to benchmark it's impact 2) pre mapped DMA addresses were not reused in the case of XDP_TX/XDP_REDIRECT I see Michael has merge this series so I'm fine to let it go first. Thanks> > Thanks. >