Stefano Garzarella
2023-Aug-02 07:46 UTC
[RFC PATCH v1 1/2] vsock: send SIGPIPE on write to shutdowned socket
On Tue, Aug 01, 2023 at 05:17:26PM +0300, Arseniy Krasnov wrote:>POSIX requires to send SIGPIPE on write to SOCK_STREAM socket which was >shutdowned with SHUT_WR flag or its peer was shutdowned with SHUT_RD >flag. Also we must not send SIGPIPE if MSG_NOSIGNAL flag is set. > >Signed-off-by: Arseniy Krasnov <AVKrasnov at sberdevices.ru> >--- > net/vmw_vsock/af_vsock.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c >index 020cf17ab7e4..013b65241b65 100644 >--- a/net/vmw_vsock/af_vsock.c >+++ b/net/vmw_vsock/af_vsock.c >@@ -1921,6 +1921,9 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg, > err = total_written; > } > out: >+ if (sk->sk_type == SOCK_STREAM) >+ err = sk_stream_error(sk, msg->msg_flags, err);Do you know why we don't need this for SOCK_SEQPACKET and SOCK_DGRAM? Thanks, Stefano>+ > release_sock(sk); > return err; > } >-- >2.25.1 >