Michael S. Tsirkin
2023-Apr-10 09:56 UTC
[PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info
On Fri, Apr 07, 2023 at 04:08:30PM -0700, Guenter Roeck wrote:> On 4/7/23 08:01, Krzysztof Kozlowski wrote: > > Statically allocated array of pointed to hwmon_channel_info can be made > > const for safety. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> > > > > --- > > > > This depends on hwmon core patch: > > https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ > > > > Therefore I propose this should also go via hwmon tree. > > I am not going to apply patches for 10+ subsystems through the hwmon tree. > This can only result in chaos. The dependent patch is available at > > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-constDoesn't it cause build errors or warnings there?> or wait until after the next commit window to apply this patch. > > Thanks, > Guenter > > > > > Cc: Jean Delvare <jdelvare at suse.com> > > Cc: Guenter Roeck <linux at roeck-us.net> > > Cc: linux-hwmon at vger.kernel.org > > --- > > drivers/vdpa/solidrun/snet_hwmon.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/vdpa/solidrun/snet_hwmon.c b/drivers/vdpa/solidrun/snet_hwmon.c > > index e695e36ff753..65304354b34a 100644 > > --- a/drivers/vdpa/solidrun/snet_hwmon.c > > +++ b/drivers/vdpa/solidrun/snet_hwmon.c > > @@ -159,7 +159,7 @@ static const struct hwmon_ops snet_hwmon_ops = { > > .read_string = snet_hwmon_read_string > > }; > > -static const struct hwmon_channel_info *snet_hwmon_info[] = { > > +static const struct hwmon_channel_info * const snet_hwmon_info[] = { > > HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_CRIT | HWMON_T_LABEL, > > HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LABEL), > > HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | HWMON_P_LABEL),
Guenter Roeck
2023-Apr-10 14:03 UTC
[PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info
On 4/10/23 02:56, Michael S. Tsirkin wrote:> On Fri, Apr 07, 2023 at 04:08:30PM -0700, Guenter Roeck wrote: >> On 4/7/23 08:01, Krzysztof Kozlowski wrote: >>> Statically allocated array of pointed to hwmon_channel_info can be made >>> const for safety. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org> >>> >>> --- >>> >>> This depends on hwmon core patch: >>> https://lore.kernel.org/all/20230406203103.3011503-2-krzysztof.kozlowski at linaro.org/ >>> >>> Therefore I propose this should also go via hwmon tree. >> >> I am not going to apply patches for 10+ subsystems through the hwmon tree. >> This can only result in chaos. The dependent patch is available at >> >> git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-const > > Doesn't it cause build errors or warnings there? >Are you saying that "hwmon: constify pointers to hwmon_channel_info" applied on its own on top of v6.3-rc5 (as done in above branch) causes build errors or warnings ? I have not seen any such reports, and I don't immediately see why that would be the case. Please elaborate. Guenter>> or wait until after the next commit window to apply this patch. >> >> Thanks, >> Guenter >> >>> >>> Cc: Jean Delvare <jdelvare at suse.com> >>> Cc: Guenter Roeck <linux at roeck-us.net> >>> Cc: linux-hwmon at vger.kernel.org >>> --- >>> drivers/vdpa/solidrun/snet_hwmon.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/vdpa/solidrun/snet_hwmon.c b/drivers/vdpa/solidrun/snet_hwmon.c >>> index e695e36ff753..65304354b34a 100644 >>> --- a/drivers/vdpa/solidrun/snet_hwmon.c >>> +++ b/drivers/vdpa/solidrun/snet_hwmon.c >>> @@ -159,7 +159,7 @@ static const struct hwmon_ops snet_hwmon_ops = { >>> .read_string = snet_hwmon_read_string >>> }; >>> -static const struct hwmon_channel_info *snet_hwmon_info[] = { >>> +static const struct hwmon_channel_info * const snet_hwmon_info[] = { >>> HWMON_CHANNEL_INFO(temp, HWMON_T_INPUT | HWMON_T_MAX | HWMON_T_CRIT | HWMON_T_LABEL, >>> HWMON_T_INPUT | HWMON_T_CRIT | HWMON_T_LABEL), >>> HWMON_CHANNEL_INFO(power, HWMON_P_INPUT | HWMON_P_LABEL), >
Reasonably Related Threads
- [PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info
- [PATCH] vdpa: solidrun: constify pointers to hwmon_channel_info
- [PATCH 0/2] vdpa/snet: support [s/g]et_vq_state and suspend
- [PATCH resend 0/2] vdpa/snet: support [s/g]et_vq_state and suspend
- [GIT PULL] virtio,vhost,vdpa: features, fixes