Michael S. Tsirkin
2021-Oct-25 08:09 UTC
[PATCH linux-next v4 5/8] vdpa_sim_net: Enable user to set mac address and mtu
On Mon, Oct 25, 2021 at 07:11:23AM +0000, Parav Pandit wrote:> > > > From: Jason Wang <jasowang at redhat.com> > > Sent: Monday, October 25, 2021 12:32 PM > > > > > > ? 2021/10/22 ??12:35, Parav Pandit ??: > > > Enable user to set the mac address and mtu so that each vdpa device > > > can have its own user specified mac address and mtu. > > > This is done by implementing the management device's configuration > > > layout fields setting callback routine. > > > > > > Now that user is enabled to set the mac address, remove the module > > > parameter for same. > > > > > > And example of setting mac addr and mtu: > > > $ vdpa mgmtdev show > > > > > > $ vdpa dev add name bar mgmtdev vdpasim_net $ vdpa dev config set bar > > > mac 00:11:22:33:44:55 mtu 9000 > > > > > > The attributes were set during dev add if I was not wrong. > > > You are right. I missed to update the example here. Code is just fine. > > > Thanks > >Want to send a corrected commit log?
Parav Pandit
2021-Oct-25 08:10 UTC
[PATCH linux-next v4 5/8] vdpa_sim_net: Enable user to set mac address and mtu
> From: Michael S. Tsirkin <mst at redhat.com> > Sent: Monday, October 25, 2021 1:39 PM > > On Mon, Oct 25, 2021 at 07:11:23AM +0000, Parav Pandit wrote: > > > > > > > From: Jason Wang <jasowang at redhat.com> > > > Sent: Monday, October 25, 2021 12:32 PM > > > > > > > > > ? 2021/10/22 ??12:35, Parav Pandit ??: > > > > Enable user to set the mac address and mtu so that each vdpa > > > > device can have its own user specified mac address and mtu. > > > > This is done by implementing the management device's configuration > > > > layout fields setting callback routine. > > > > > > > > Now that user is enabled to set the mac address, remove the module > > > > parameter for same. > > > > > > > > And example of setting mac addr and mtu: > > > > $ vdpa mgmtdev show > > > > > > > > $ vdpa dev add name bar mgmtdev vdpasim_net $ vdpa dev config set > > > > bar mac 00:11:22:33:44:55 mtu 9000 > > > > > > > > > The attributes were set during dev add if I was not wrong. > > > > > You are right. I missed to update the example here. Code is just fine. > > > > > Thanks > > > > > Want to send a corrected commit log?Yes. would like to send v5 with the corrected commit log and ACK from Jason on other patches.