Hi
Am 20.01.21 um 12:12 schrieb Gerd Hoffmann:> Balances the qxl_create_bo(..., pinned=true, ...);
> call in qxl_release_bo_alloc().
>
> Signed-off-by: Gerd Hoffmann <kraxel at redhat.com>
> ---
> drivers/gpu/drm/qxl/qxl_release.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/qxl/qxl_release.c
b/drivers/gpu/drm/qxl/qxl_release.c
> index 0fcfc952d5e9..add979cba11b 100644
> --- a/drivers/gpu/drm/qxl/qxl_release.c
> +++ b/drivers/gpu/drm/qxl/qxl_release.c
> @@ -166,6 +166,7 @@ qxl_release_free_list(struct qxl_release *release)
> entry = container_of(release->bos.next,
> struct qxl_bo_list, tv.head);
> bo = to_qxl_bo(entry->tv.bo);
> + bo->tbo.pin_count = 0; /* ttm_bo_unpin(&bo->tbo); */
This code looks like a workaround or a bug.
AFAICT the only place with pre-pinned BO is qdev->dumb_shadow_bo. Can
you remove the pinned flag entirely and handle pinning as part of
dumb_shadow_bo's code.
Otherwise maybe use
if (pin_count)
ttm_bo_unpin();
WARN_ON(pin_count); /* should always be 0 now */
with a comment similar to the commit's description.
Best regards
Thomas
> qxl_bo_unref(&bo);
> list_del(&entry->tv.head);
> kfree(entry);
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 N?rnberg, Germany
(HRB 36809, AG N?rnberg)
Gesch?ftsf?hrer: Felix Imend?rffer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20210122/3056125a/attachment-0001.sig>