Tonghao Zhang
2018-Jul-11 03:49 UTC
[PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
On Wed, Jul 11, 2018 at 10:56 AM Jason Wang <jasowang at redhat.com> wrote:> > > > On 2018?07?04? 12:31, xiangxia.m.yue at gmail.com wrote: > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > This patches improve the guest receive and transmit performance. > > On the handle_tx side, we poll the sock receive queue at the same time. > > handle_rx do that in the same way. > > > > For more performance report, see patch 4. > > > > v4 -> v5: > > fix some issues > > > > v3 -> v4: > > fix some issues > > > > v2 -> v3: > > This patches are splited from previous big patch: > > http://patchwork.ozlabs.org/patch/934673/ > > > > Tonghao Zhang (4): > > vhost: lock the vqs one by one > > net: vhost: replace magic number of lock annotation > > net: vhost: factor out busy polling logic to vhost_net_busy_poll() > > net: vhost: add rx busy polling in tx path > > > > drivers/vhost/net.c | 108 ++++++++++++++++++++++++++++---------------------- > > drivers/vhost/vhost.c | 24 ++++------- > > 2 files changed, 67 insertions(+), 65 deletions(-) > > > > Hi, any progress on the new version? > > I plan to send a new series of packed virtqueue support of vhost. If you > plan to send it soon, I can wait. Otherwise, I will send my series.I rebase the codes. and find there is no improvement anymore, the patches of makita may solve the problem. jason you may send your patches, and I will do some research on busypoll.> Thanks
Jason Wang
2018-Jul-11 05:12 UTC
[PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
On 2018?07?11? 11:49, Tonghao Zhang wrote:> On Wed, Jul 11, 2018 at 10:56 AM Jason Wang <jasowang at redhat.com> wrote: >> >> >> On 2018?07?04? 12:31, xiangxia.m.yue at gmail.com wrote: >>> From: Tonghao Zhang <xiangxia.m.yue at gmail.com> >>> >>> This patches improve the guest receive and transmit performance. >>> On the handle_tx side, we poll the sock receive queue at the same time. >>> handle_rx do that in the same way. >>> >>> For more performance report, see patch 4. >>> >>> v4 -> v5: >>> fix some issues >>> >>> v3 -> v4: >>> fix some issues >>> >>> v2 -> v3: >>> This patches are splited from previous big patch: >>> http://patchwork.ozlabs.org/patch/934673/ >>> >>> Tonghao Zhang (4): >>> vhost: lock the vqs one by one >>> net: vhost: replace magic number of lock annotation >>> net: vhost: factor out busy polling logic to vhost_net_busy_poll() >>> net: vhost: add rx busy polling in tx path >>> >>> drivers/vhost/net.c | 108 ++++++++++++++++++++++++++++---------------------- >>> drivers/vhost/vhost.c | 24 ++++------- >>> 2 files changed, 67 insertions(+), 65 deletions(-) >>> >> Hi, any progress on the new version? >> >> I plan to send a new series of packed virtqueue support of vhost. If you >> plan to send it soon, I can wait. Otherwise, I will send my series. > I rebase the codes. and find there is no improvement anymore, the > patches of makita may solve the problem. jason you may send your > patches, and I will do some research on busypoll.I see. Maybe you can try some bi-directional traffic. Btw, lots of optimizations could be done for busy polling. E.g integrating with host NAPI busy polling or a 100% busy polling vhost_net. You're welcome to work or propose new ideas. Thanks> >> Thanks
Michael S. Tsirkin
2018-Jul-11 11:59 UTC
[PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wang wrote:> > > On 2018?07?11? 11:49, Tonghao Zhang wrote: > > On Wed, Jul 11, 2018 at 10:56 AM Jason Wang <jasowang at redhat.com> wrote: > > > > > > > > > On 2018?07?04? 12:31, xiangxia.m.yue at gmail.com wrote: > > > > From: Tonghao Zhang <xiangxia.m.yue at gmail.com> > > > > > > > > This patches improve the guest receive and transmit performance. > > > > On the handle_tx side, we poll the sock receive queue at the same time. > > > > handle_rx do that in the same way. > > > > > > > > For more performance report, see patch 4. > > > > > > > > v4 -> v5: > > > > fix some issues > > > > > > > > v3 -> v4: > > > > fix some issues > > > > > > > > v2 -> v3: > > > > This patches are splited from previous big patch: > > > > http://patchwork.ozlabs.org/patch/934673/ > > > > > > > > Tonghao Zhang (4): > > > > vhost: lock the vqs one by one > > > > net: vhost: replace magic number of lock annotation > > > > net: vhost: factor out busy polling logic to vhost_net_busy_poll() > > > > net: vhost: add rx busy polling in tx path > > > > > > > > drivers/vhost/net.c | 108 ++++++++++++++++++++++++++++---------------------- > > > > drivers/vhost/vhost.c | 24 ++++------- > > > > 2 files changed, 67 insertions(+), 65 deletions(-) > > > > > > > Hi, any progress on the new version? > > > > > > I plan to send a new series of packed virtqueue support of vhost. If you > > > plan to send it soon, I can wait. Otherwise, I will send my series. > > I rebase the codes. and find there is no improvement anymore, the > > patches of makita may solve the problem. jason you may send your > > patches, and I will do some research on busypoll. > > I see. Maybe you can try some bi-directional traffic. > > Btw, lots of optimizations could be done for busy polling. E.g integrating > with host NAPI busy polling or a 100% busy polling vhost_net. You're welcome > to work or propose new ideas. > > ThanksIt seems clear we do need adaptive polling. The difficulty with NAPI polling is it can't access guest memory easily. But maybe get_user_pages on the polled memory+NAPI polling can work.> > > > > Thanks
Possibly Parallel Threads
- [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
- [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
- [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
- [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop
- [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop