Jarod Wilson
2016-Oct-19 02:33 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
hyperv_net: - set min/max_mtu virtio_net: - set min/max_mtu - remove virtnet_change_mtu vmxnet3: - set min/max_mtu CC: netdev at vger.kernel.org CC: virtualization at lists.linux-foundation.org CC: "K. Y. Srinivasan" <kys at microsoft.com> CC: Haiyang Zhang <haiyangz at microsoft.com> CC: "Michael S. Tsirkin" <mst at redhat.com> CC: Shrikrishna Khare <skhare at vmware.com> CC: "VMware, Inc." <pv-drivers at vmware.com> Signed-off-by: Jarod Wilson <jarod at redhat.com> --- drivers/net/hyperv/hyperv_net.h | 4 ++-- drivers/net/hyperv/netvsc_drv.c | 14 +++++++------- drivers/net/virtio_net.c | 23 ++++++++++------------- drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++++--- 4 files changed, 23 insertions(+), 25 deletions(-) diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h index f4fbcb5..3958ada 100644 --- a/drivers/net/hyperv/hyperv_net.h +++ b/drivers/net/hyperv/hyperv_net.h @@ -606,8 +606,8 @@ struct nvsp_message { } __packed; -#define NETVSC_MTU 65536 -#define NETVSC_MTU_MIN 68 +#define NETVSC_MTU 65535 +#define NETVSC_MTU_MIN ETH_MIN_MTU #define NETVSC_RECEIVE_BUFFER_SIZE (1024*1024*16) /* 16MB */ #define NETVSC_RECEIVE_BUFFER_SIZE_LEGACY (1024*1024*15) /* 15MB */ diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index f0919bd..3dc9679 100644 --- a/drivers/net/hyperv/netvsc_drv.c +++ b/drivers/net/hyperv/netvsc_drv.c @@ -872,19 +872,12 @@ static int netvsc_change_mtu(struct net_device *ndev, int mtu) struct netvsc_device *nvdev = ndevctx->nvdev; struct hv_device *hdev = ndevctx->device_ctx; struct netvsc_device_info device_info; - int limit = ETH_DATA_LEN; u32 num_chn; int ret = 0; if (ndevctx->start_remove || !nvdev || nvdev->destroy) return -ENODEV; - if (nvdev->nvsp_version >= NVSP_PROTOCOL_VERSION_2) - limit = NETVSC_MTU - ETH_HLEN; - - if (mtu < NETVSC_MTU_MIN || mtu > limit) - return -EINVAL; - ret = netvsc_close(ndev); if (ret) goto out; @@ -1343,6 +1336,13 @@ static int netvsc_probe(struct hv_device *dev, netif_carrier_off(net); + /* MTU range: 68 - 1500 or 65521 */ + net->min_mtu = NETVSC_MTU_MIN; + if (nvdev->nvsp_version >= NVSP_PROTOCOL_VERSION_2) + net->max_mtu = NETVSC_MTU - ETH_HLEN; + else + net->max_mtu = ETH_DATA_LEN; + netvsc_init_settings(net); net_device_ctx = netdev_priv(net); diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index fad84f3..4885a42 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -1419,17 +1419,6 @@ static const struct ethtool_ops virtnet_ethtool_ops = { .set_settings = virtnet_set_settings, }; -#define MIN_MTU 68 -#define MAX_MTU 65535 - -static int virtnet_change_mtu(struct net_device *dev, int new_mtu) -{ - if (new_mtu < MIN_MTU || new_mtu > MAX_MTU) - return -EINVAL; - dev->mtu = new_mtu; - return 0; -} - static const struct net_device_ops virtnet_netdev = { .ndo_open = virtnet_open, .ndo_stop = virtnet_close, @@ -1437,7 +1426,6 @@ static const struct net_device_ops virtnet_netdev = { .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = virtnet_set_mac_address, .ndo_set_rx_mode = virtnet_set_rx_mode, - .ndo_change_mtu = virtnet_change_mtu, .ndo_get_stats64 = virtnet_stats, .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, @@ -1748,6 +1736,9 @@ static bool virtnet_validate_features(struct virtio_device *vdev) return true; } +#define MIN_MTU ETH_MIN_MTU +#define MAX_MTU 65535 + static int virtnet_probe(struct virtio_device *vdev) { int i, err; @@ -1821,6 +1812,10 @@ static int virtnet_probe(struct virtio_device *vdev) dev->vlan_features = dev->features; + /* MTU range: 68 - 65535 */ + dev->min_mtu = MIN_MTU; + dev->max_mtu = MAX_MTU; + /* Configuration may specify what MAC to use. Otherwise random. */ if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) virtio_cread_bytes(vdev, @@ -1875,8 +1870,10 @@ static int virtnet_probe(struct virtio_device *vdev) mtu = virtio_cread16(vdev, offsetof(struct virtio_net_config, mtu)); - if (virtnet_change_mtu(dev, mtu)) + if (mtu >= dev->min_mtu && mtu <= dev->max_mtu) { + dev->mtu = mtu; __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU); + } } if (vi->any_header_sg) diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c index b5554f2..0c36de1 100644 --- a/drivers/net/vmxnet3/vmxnet3_drv.c +++ b/drivers/net/vmxnet3/vmxnet3_drv.c @@ -2969,9 +2969,6 @@ vmxnet3_change_mtu(struct net_device *netdev, int new_mtu) struct vmxnet3_adapter *adapter = netdev_priv(netdev); int err = 0; - if (new_mtu < VMXNET3_MIN_MTU || new_mtu > VMXNET3_MAX_MTU) - return -EINVAL; - netdev->mtu = new_mtu; /* @@ -3428,6 +3425,10 @@ vmxnet3_probe_device(struct pci_dev *pdev, vmxnet3_set_ethtool_ops(netdev); netdev->watchdog_timeo = 5 * HZ; + /* MTU range: 60 - 9000 */ + netdev->min_mtu = VMXNET3_MIN_MTU; + netdev->max_mtu = VMXNET3_MAX_MTU; + INIT_WORK(&adapter->work, vmxnet3_reset_work); set_bit(VMXNET3_STATE_BIT_QUIESCED, &adapter->state); -- 2.10.0
Aaron Conole
2016-Oct-19 13:06 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
Jarod Wilson <jarod at redhat.com> writes:> hyperv_net: > - set min/max_mtu > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > > vmxnet3: > - set min/max_mtu > > CC: netdev at vger.kernel.org > CC: virtualization at lists.linux-foundation.org > CC: "K. Y. Srinivasan" <kys at microsoft.com> > CC: Haiyang Zhang <haiyangz at microsoft.com> > CC: "Michael S. Tsirkin" <mst at redhat.com> > CC: Shrikrishna Khare <skhare at vmware.com> > CC: "VMware, Inc." <pv-drivers at vmware.com> > Signed-off-by: Jarod Wilson <jarod at redhat.com> > ---The virtnet change looks good to me. It simplifies an enhancement that I was about to propose, so I'll let yours land first. -Aaron
Michael S. Tsirkin
2016-Oct-19 13:59 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
On Tue, Oct 18, 2016 at 10:33:32PM -0400, Jarod Wilson wrote:> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index fad84f3..4885a42 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -1419,17 +1419,6 @@ static const struct ethtool_ops virtnet_ethtool_ops = { > .set_settings = virtnet_set_settings, > }; > > -#define MIN_MTU 68 > -#define MAX_MTU 65535 > - > -static int virtnet_change_mtu(struct net_device *dev, int new_mtu) > -{ > - if (new_mtu < MIN_MTU || new_mtu > MAX_MTU) > - return -EINVAL; > - dev->mtu = new_mtu; > - return 0; > -} > - > static const struct net_device_ops virtnet_netdev = { > .ndo_open = virtnet_open, > .ndo_stop = virtnet_close, > @@ -1437,7 +1426,6 @@ static const struct net_device_ops virtnet_netdev = { > .ndo_validate_addr = eth_validate_addr, > .ndo_set_mac_address = virtnet_set_mac_address, > .ndo_set_rx_mode = virtnet_set_rx_mode, > - .ndo_change_mtu = virtnet_change_mtu, > .ndo_get_stats64 = virtnet_stats, > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > @@ -1748,6 +1736,9 @@ static bool virtnet_validate_features(struct virtio_device *vdev) > return true; > } > > +#define MIN_MTU ETH_MIN_MTU > +#define MAX_MTU 65535 > +Do we need a common macro for this?> static int virtnet_probe(struct virtio_device *vdev) > { > int i, err; > @@ -1821,6 +1812,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > dev->vlan_features = dev->features; > > + /* MTU range: 68 - 65535 */ > + dev->min_mtu = MIN_MTU; > + dev->max_mtu = MAX_MTU; > + > /* Configuration may specify what MAC to use. Otherwise random. */ > if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) > virtio_cread_bytes(vdev, > @@ -1875,8 +1870,10 @@ static int virtnet_probe(struct virtio_device *vdev) > mtu = virtio_cread16(vdev, > offsetof(struct virtio_net_config, > mtu)); > - if (virtnet_change_mtu(dev, mtu)) > + if (mtu >= dev->min_mtu && mtu <= dev->max_mtu) { > + dev->mtu = mtu; > __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU);I think the logic is wrong here: If mtu is legal, we set it but do not tell host. If it's out of range we tell host we use it but don't actually. Should be the reverse.> + } > } > > if (vi->any_header_sg)-- MST
Michael S. Tsirkin
2016-Oct-19 14:03 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
On Wed, Oct 19, 2016 at 04:59:46PM +0300, Michael S. Tsirkin wrote:> On Tue, Oct 18, 2016 at 10:33:32PM -0400, Jarod Wilson wrote: > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index fad84f3..4885a42 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -1419,17 +1419,6 @@ static const struct ethtool_ops virtnet_ethtool_ops = { > > .set_settings = virtnet_set_settings, > > }; > > > > -#define MIN_MTU 68 > > -#define MAX_MTU 65535 > > - > > -static int virtnet_change_mtu(struct net_device *dev, int new_mtu) > > -{ > > - if (new_mtu < MIN_MTU || new_mtu > MAX_MTU) > > - return -EINVAL; > > - dev->mtu = new_mtu; > > - return 0; > > -} > > - > > static const struct net_device_ops virtnet_netdev = { > > .ndo_open = virtnet_open, > > .ndo_stop = virtnet_close, > > @@ -1437,7 +1426,6 @@ static const struct net_device_ops virtnet_netdev = { > > .ndo_validate_addr = eth_validate_addr, > > .ndo_set_mac_address = virtnet_set_mac_address, > > .ndo_set_rx_mode = virtnet_set_rx_mode, > > - .ndo_change_mtu = virtnet_change_mtu, > > .ndo_get_stats64 = virtnet_stats, > > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > > @@ -1748,6 +1736,9 @@ static bool virtnet_validate_features(struct virtio_device *vdev) > > return true; > > } > > > > +#define MIN_MTU ETH_MIN_MTU > > +#define MAX_MTU 65535 > > + > > Do we need a common macro for this?I think it's actually IP_MAX_MTU.> > static int virtnet_probe(struct virtio_device *vdev) > > { > > int i, err; > > @@ -1821,6 +1812,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > > > dev->vlan_features = dev->features; > > > > + /* MTU range: 68 - 65535 */ > > + dev->min_mtu = MIN_MTU; > > + dev->max_mtu = MAX_MTU; > > + > > /* Configuration may specify what MAC to use. Otherwise random. */ > > if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) > > virtio_cread_bytes(vdev, > > @@ -1875,8 +1870,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > mtu = virtio_cread16(vdev, > > offsetof(struct virtio_net_config, > > mtu)); > > - if (virtnet_change_mtu(dev, mtu)) > > + if (mtu >= dev->min_mtu && mtu <= dev->max_mtu) { > > + dev->mtu = mtu; > > __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU); > > I think the logic is wrong here: > > If mtu is legal, we set it but do not tell host. > If it's out of range we tell host we use it > but don't actually. > > Should be the reverse. > > > + } > > } > > > > if (vi->any_header_sg) > > -- > MST
Haiyang Zhang
2016-Oct-19 14:07 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
> -----Original Message----- > From: Jarod Wilson [mailto:jarod at redhat.com] > Sent: Tuesday, October 18, 2016 10:34 PM > To: linux-kernel at vger.kernel.org > Cc: Jarod Wilson <jarod at redhat.com>; netdev at vger.kernel.org; > virtualization at lists.linux-foundation.org; KY Srinivasan > <kys at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>; Michael S. > Tsirkin <mst at redhat.com>; Shrikrishna Khare <skhare at vmware.com>; VMware, > Inc. <pv-drivers at vmware.com> > Subject: [PATCH net-next 5/6] net: use core MTU range checking in virt > drivers > > hyperv_net: > - set min/max_mtu > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > > vmxnet3: > - set min/max_mtu > > CC: netdev at vger.kernel.org > CC: virtualization at lists.linux-foundation.org > CC: "K. Y. Srinivasan" <kys at microsoft.com> > CC: Haiyang Zhang <haiyangz at microsoft.com> > CC: "Michael S. Tsirkin" <mst at redhat.com> > CC: Shrikrishna Khare <skhare at vmware.com> > CC: "VMware, Inc." <pv-drivers at vmware.com> > Signed-off-by: Jarod Wilson <jarod at redhat.com> > --- > drivers/net/hyperv/hyperv_net.h | 4 ++-- > drivers/net/hyperv/netvsc_drv.c | 14 +++++++------- > drivers/net/virtio_net.c | 23 ++++++++++------------- > drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++++--- > 4 files changed, 23 insertions(+), 25 deletions(-) > > diff --git a/drivers/net/hyperv/hyperv_net.h > b/drivers/net/hyperv/hyperv_net.h > index f4fbcb5..3958ada 100644 > --- a/drivers/net/hyperv/hyperv_net.h > +++ b/drivers/net/hyperv/hyperv_net.h > @@ -606,8 +606,8 @@ struct nvsp_message { > } __packed; > > > -#define NETVSC_MTU 65536 > -#define NETVSC_MTU_MIN 68 > +#define NETVSC_MTU 65535Why change it to 65535? For Hyperv host, this should be 65536.> @@ -1343,6 +1336,13 @@ static int netvsc_probe(struct hv_device *dev, > > netif_carrier_off(net); > > + /* MTU range: 68 - 1500 or 65521 */ > + net->min_mtu = NETVSC_MTU_MIN; > + if (nvdev->nvsp_version >= NVSP_PROTOCOL_VERSION_2) > + net->max_mtu = NETVSC_MTU - ETH_HLEN; > + else > + net->max_mtu = ETH_DATA_LEN; > + > netvsc_init_settings(net); > > net_device_ctx = netdev_priv(net);nvdev->nvsp_version is not set until after rndis_filter_device_add() is successfully completed. You need to move this part to the place just before this line: ret = register_netdev(net); Thanks, - Haiyang
Jarod Wilson
2016-Oct-19 14:15 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
On Wed, Oct 19, 2016 at 04:59:46PM +0300, Michael S. Tsirkin wrote:> On Tue, Oct 18, 2016 at 10:33:32PM -0400, Jarod Wilson wrote: > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index fad84f3..4885a42 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -1419,17 +1419,6 @@ static const struct ethtool_ops virtnet_ethtool_ops = { > > .set_settings = virtnet_set_settings, > > }; > > > > -#define MIN_MTU 68 > > -#define MAX_MTU 65535 > > - > > -static int virtnet_change_mtu(struct net_device *dev, int new_mtu) > > -{ > > - if (new_mtu < MIN_MTU || new_mtu > MAX_MTU) > > - return -EINVAL; > > - dev->mtu = new_mtu; > > - return 0; > > -} > > - > > static const struct net_device_ops virtnet_netdev = { > > .ndo_open = virtnet_open, > > .ndo_stop = virtnet_close, > > @@ -1437,7 +1426,6 @@ static const struct net_device_ops virtnet_netdev = { > > .ndo_validate_addr = eth_validate_addr, > > .ndo_set_mac_address = virtnet_set_mac_address, > > .ndo_set_rx_mode = virtnet_set_rx_mode, > > - .ndo_change_mtu = virtnet_change_mtu, > > .ndo_get_stats64 = virtnet_stats, > > .ndo_vlan_rx_add_vid = virtnet_vlan_rx_add_vid, > > .ndo_vlan_rx_kill_vid = virtnet_vlan_rx_kill_vid, > > @@ -1748,6 +1736,9 @@ static bool virtnet_validate_features(struct virtio_device *vdev) > > return true; > > } > > > > +#define MIN_MTU ETH_MIN_MTU > > +#define MAX_MTU 65535 > > + > > Do we need a common macro for this?Probably. That value crops up in multiple drivers.> > static int virtnet_probe(struct virtio_device *vdev) > > { > > int i, err; > > @@ -1821,6 +1812,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > > > dev->vlan_features = dev->features; > > > > + /* MTU range: 68 - 65535 */ > > + dev->min_mtu = MIN_MTU; > > + dev->max_mtu = MAX_MTU; > > + > > /* Configuration may specify what MAC to use. Otherwise random. */ > > if (virtio_has_feature(vdev, VIRTIO_NET_F_MAC)) > > virtio_cread_bytes(vdev, > > @@ -1875,8 +1870,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > mtu = virtio_cread16(vdev, > > offsetof(struct virtio_net_config, > > mtu)); > > - if (virtnet_change_mtu(dev, mtu)) > > + if (mtu >= dev->min_mtu && mtu <= dev->max_mtu) { > > + dev->mtu = mtu; > > __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU); > > I think the logic is wrong here: > > If mtu is legal, we set it but do not tell host. > If it's out of range we tell host we use it > but don't actually. > > Should be the reverse.Ah, yes, looks like it should be: if (mtu < dev->min_mtu || mtu > dev->max_mtu) __virtio_clear_bit(vdev, VIRTIO_NET_F_MTU); else dev->mtu = mtu; -- Jarod Wilson jarod at redhat.com
Jarod Wilson
2016-Oct-19 14:23 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
On Wed, Oct 19, 2016 at 02:07:47PM +0000, Haiyang Zhang wrote:> > > > -----Original Message----- > > From: Jarod Wilson [mailto:jarod at redhat.com] > > Sent: Tuesday, October 18, 2016 10:34 PM > > To: linux-kernel at vger.kernel.org > > Cc: Jarod Wilson <jarod at redhat.com>; netdev at vger.kernel.org; > > virtualization at lists.linux-foundation.org; KY Srinivasan > > <kys at microsoft.com>; Haiyang Zhang <haiyangz at microsoft.com>; Michael S. > > Tsirkin <mst at redhat.com>; Shrikrishna Khare <skhare at vmware.com>; VMware, > > Inc. <pv-drivers at vmware.com> > > Subject: [PATCH net-next 5/6] net: use core MTU range checking in virt > > drivers > > > > hyperv_net: > > - set min/max_mtu > > > > virtio_net: > > - set min/max_mtu > > - remove virtnet_change_mtu > > > > vmxnet3: > > - set min/max_mtu > > > > CC: netdev at vger.kernel.org > > CC: virtualization at lists.linux-foundation.org > > CC: "K. Y. Srinivasan" <kys at microsoft.com> > > CC: Haiyang Zhang <haiyangz at microsoft.com> > > CC: "Michael S. Tsirkin" <mst at redhat.com> > > CC: Shrikrishna Khare <skhare at vmware.com> > > CC: "VMware, Inc." <pv-drivers at vmware.com> > > Signed-off-by: Jarod Wilson <jarod at redhat.com> > > --- > > drivers/net/hyperv/hyperv_net.h | 4 ++-- > > drivers/net/hyperv/netvsc_drv.c | 14 +++++++------- > > drivers/net/virtio_net.c | 23 ++++++++++------------- > > drivers/net/vmxnet3/vmxnet3_drv.c | 7 ++++--- > > 4 files changed, 23 insertions(+), 25 deletions(-) > > > > diff --git a/drivers/net/hyperv/hyperv_net.h > > b/drivers/net/hyperv/hyperv_net.h > > index f4fbcb5..3958ada 100644 > > --- a/drivers/net/hyperv/hyperv_net.h > > +++ b/drivers/net/hyperv/hyperv_net.h > > @@ -606,8 +606,8 @@ struct nvsp_message { > > } __packed; > > > > > > -#define NETVSC_MTU 65536 > > -#define NETVSC_MTU_MIN 68 > > +#define NETVSC_MTU 65535 > > Why change it to 65535? For Hyperv host, this should be 65536.Forgot to call this change out, sorry. That was changed, because of IP_MAX_MTU being 0xFFFFU -> 65535.> > @@ -1343,6 +1336,13 @@ static int netvsc_probe(struct hv_device *dev, > > > > netif_carrier_off(net); > > > > + /* MTU range: 68 - 1500 or 65521 */ > > + net->min_mtu = NETVSC_MTU_MIN; > > + if (nvdev->nvsp_version >= NVSP_PROTOCOL_VERSION_2) > > + net->max_mtu = NETVSC_MTU - ETH_HLEN; > > + else > > + net->max_mtu = ETH_DATA_LEN; > > + > > netvsc_init_settings(net); > > > > net_device_ctx = netdev_priv(net); > > nvdev->nvsp_version is not set until after rndis_filter_device_add() > is successfully completed. > You need to move this part to the place just before this line: > ret = register_netdev(net);Okay, will fix that up. -- Jarod Wilson jarod at redhat.com
Shrikrishna Khare
2016-Oct-19 22:21 UTC
[PATCH net-next 5/6] net: use core MTU range checking in virt drivers
On Wed, 19 Oct 2016, Jarod Wilson wrote:> hyperv_net: > - set min/max_mtu > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > > vmxnet3: > - set min/max_mtu > > CC: netdev at vger.kernel.org > CC: virtualization at lists.linux-foundation.org > CC: "K. Y. Srinivasan" <kys at microsoft.com> > CC: Haiyang Zhang <haiyangz at microsoft.com> > CC: "Michael S. Tsirkin" <mst at redhat.com> > CC: Shrikrishna Khare <skhare at vmware.com> > CC: "VMware, Inc." <pv-drivers at vmware.com> > Signed-off-by: Jarod Wilson <jarod at redhat.com> > ---The vmxnet3 part of the change looks good to me. Thanks, Shri
Maybe Matching Threads
- [PATCH net-next 5/6] net: use core MTU range checking in virt drivers
- [PATCH net-next 5/6] net: use core MTU range checking in virt drivers
- [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers
- [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers
- [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers