Zachary Amsden wrote:> In compat mode, the return value here was uninitialized. > > Signed-off-by: Zachary Amsden <zach@vmware.com> > > diff -r 1fda49a076ed arch/i386/kernel/sysenter.c > --- a/arch/i386/kernel/sysenter.c Fri Apr 06 14:25:09 2007 -0700 > +++ b/arch/i386/kernel/sysenter.c Fri Apr 06 14:27:31 2007 -0700 > @@ -254,7 +254,7 @@ int arch_setup_additional_pages(struct l > { > struct mm_struct *mm = current->mm; > unsigned long addr; > - int ret; > + int ret = 0; > bool compat; > > down_write(&mm->mmap_sem); > -Hm, OK, but what about just zeroing it in the compat leg of the if()? J
In compat mode, the return value here was uninitialized. Signed-off-by: Zachary Amsden <zach@vmware.com> diff -r 1fda49a076ed arch/i386/kernel/sysenter.c --- a/arch/i386/kernel/sysenter.c Fri Apr 06 14:25:09 2007 -0700 +++ b/arch/i386/kernel/sysenter.c Fri Apr 06 14:27:31 2007 -0700 @@ -254,7 +254,7 @@ int arch_setup_additional_pages(struct l { struct mm_struct *mm = current->mm; unsigned long addr; - int ret; + int ret = 0; bool compat; down_write(&mm->mmap_sem);
Apparently Analagous Threads
- [PATCH 1/10] I386 sysenter arch pages fix.patch
- [patch 0/2] Updates to compat VDSOs
- [patch 0/2] Updates to compat VDSOs
- [patch 0/4] Clean up asm/bugs.h, identify_cpu() and update COMPAT_VDSO
- [patch 0/4] Clean up asm/bugs.h, identify_cpu() and update COMPAT_VDSO