Jakub Kicinski
2022-Feb-24 16:06 UTC
[Bridge] [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries
On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote:> On 23/02/2022 19:24, Joachim Wiberg wrote: > > This patch expands on the earlier work on layer-2 mdb entries by adding > > support for host entries. Due to the fact that host joined entries do > > not have any flag field, we infer the permanent flag when reporting the > > entries to userspace, which otherwise would be listed as 'temp'. > > > > Before patch: > > > > ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee permanent > > Error: bridge: Flags are not allowed for host groups. > > ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee > > Error: bridge: Only permanent L2 entries allowed. > > > > After patch: > > > > ~# bridge mdb add dev br0 port br0 grp 01:00:00:c0:ff:ee permanent > > ~# bridge mdb show > > dev br0 port br0 grp 01:00:00:c0:ff:ee permanent vid 1 > > > > Signed-off-by: Joachim Wiberg <troglobit at gmail.com> > > It would be nice to add a selftest for L2 entries. You can send it as a follow-up.Let's wait for that, also checkpatch says you need to balance brackets to hold kernel coding style.> Acked-by: Nikolay Aleksandrov <razor at blackwall.org>
Joachim Wiberg
2022-Feb-24 16:29 UTC
[Bridge] [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries
On Thu, Feb 24, 2022 at 08:06, Jakub Kicinski <kuba at kernel.org> wrote:> On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote: >> On 23/02/2022 19:24, Joachim Wiberg wrote: >> > This patch expands on the earlier work on layer-2 mdb entries by adding >> > support for host entries. >> It would be nice to add a selftest for L2 entries. You can send it as a follow-up. > Let's wait for that, also checkpatch says you need to balance brackets > to hold kernel coding style.Jakub, by "wait for that" do you mean you'd prefer I add the selftests to this? Otherwise I'll send a v2 with the style fixes. Best regards /Joachim