madhuparnabhowmik10 at gmail.com
2020-Feb-19 15:17 UTC
[Bridge] [PATCH] bridge: br_stp: Use built-in RCU list checking
From: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com> list_for_each_entry_rcu() has built-in RCU and lock checking. Pass cond argument to list_for_each_entry_rcu() to silence false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled by default. Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com> --- net/bridge/br_stp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c index 1f1410f8d312..8be12452071b 100644 --- a/net/bridge/br_stp.c +++ b/net/bridge/br_stp.c @@ -52,7 +52,8 @@ struct net_bridge_port *br_get_port(struct net_bridge *br, u16 port_no) { struct net_bridge_port *p; - list_for_each_entry_rcu(p, &br->port_list, list) { + list_for_each_entry_rcu(p, &br->port_list, list, + lockdep_is_held(&br->lock)) { if (p->port_no == port_no) return p; } -- 2.17.1
David Miller
2020-Feb-19 19:14 UTC
[Bridge] [PATCH] bridge: br_stp: Use built-in RCU list checking
From: madhuparnabhowmik10 at gmail.com Date: Wed, 19 Feb 2020 20:47:46 +0530> From: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com> > > list_for_each_entry_rcu() has built-in RCU and lock checking. > > Pass cond argument to list_for_each_entry_rcu() to silence > false lockdep warning when CONFIG_PROVE_RCU_LIST is enabled > by default. > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10 at gmail.com>Applied, thank you.