%ul would print an unsigned value and a letter l, likely it was %lu that was meant to print the long int, but in reality the values printed there are just regular signed ints, so just dropping the l altogether. Signed-off-by: Oleg Drokin <green at linuxhacker.ru> --- net/bridge/br_stp_bpdu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c index 5881fbc..15c4a9c 100644 --- a/net/bridge/br_stp_bpdu.c +++ b/net/bridge/br_stp_bpdu.c @@ -230,7 +230,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb, if (net_ratelimit()) br_notice(p->br, "port %u config from %pM" - " (message_age %ul > max_age %ul)\n", + " (message_age %u > max_age %u)\n", p->port_no, eth_hdr(skb)->h_source, bpdu.message_age, bpdu.max_age); -- 2.7.4
Hello. On 8/27/2016 6:10 AM, Oleg Drokin wrote:> %ul would print an unsigned value and a letter l, > likely it was %lu that was meant to print the long int, > but in reality the values printed there are just regular signedSigned? Then you need probably "%d" or "%i"...> ints, so just dropping the l altogether. > > Signed-off-by: Oleg Drokin <green at linuxhacker.ru>[...] MBR, Sergei
Stephen Hemminger
2017-Oct-03 20:43 UTC
[Bridge] [PATCH] bridge: Fix format string for %ul
On Fri, 26 Aug 2016 23:10:28 -0400 Oleg Drokin <green at linuxhacker.ru> wrote:> %ul would print an unsigned value and a letter l, > likely it was %lu that was meant to print the long int, > but in reality the values printed there are just regular signed > ints, so just dropping the l altogether. > > Signed-off-by: Oleg Drokin <green at linuxhacker.ru> > --- > net/bridge/br_stp_bpdu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bridge/br_stp_bpdu.c b/net/bridge/br_stp_bpdu.c > index 5881fbc..15c4a9c 100644 > --- a/net/bridge/br_stp_bpdu.c > +++ b/net/bridge/br_stp_bpdu.c > @@ -230,7 +230,7 @@ void br_stp_rcv(const struct stp_proto *proto, struct sk_buff *skb, > if (net_ratelimit()) > br_notice(p->br, > "port %u config from %pM" > - " (message_age %ul > max_age %ul)\n", > + " (message_age %u > max_age %u)\n", > p->port_no, > eth_hdr(skb)->h_source, > bpdu.message_age, bpdu.max_age);Could you make the format string a single line plwase. And add Fixes tag.