Nikolay Aleksandrov
2016-Mar-16 14:30 UTC
[Bridge] [PATCH net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl
On 03/16/2016 02:34 PM, Xin Long wrote:> This patchset is used to support sending rntl info to user in some places, > and ensure that whenever those attributes change internally or from sysfs, > that a netlink notification is sent out to listeners. > > It also make some adjustment in bridge sysfs so that we can implement this > easily. > > I've done some tests on this patchset, like: > [br_sysfs] > 1. change all the attribute values of br or brif: > $ echo $value > /sys/class/net/br0/bridge/{*} > $ echo $value > /sys/class/net/br0/brif/eth1/{*} > > 2. meanwhile, on another terminal to observe the msg: > $ bridge monitor > > [br_ioctl] > 1. in bridge-utils package, do some changes in br_set, let brctl command > use ioctl to set attribute: > if ((ret = set_sysfs(path, value)) < 0) { --> > if (1) { > > $ brctl set* > > 2. meanwhile, on another terminal to observe the msg: > $ bridge monitor > > This test covers all the attributes that brctl and sysfs support to set. >Please also include the bridge maintainers (CCed).
Xin Long
2016-Mar-16 14:59 UTC
[Bridge] [PATCH net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl
On Wed, Mar 16, 2016 at 10:30 PM, Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:> On 03/16/2016 02:34 PM, Xin Long wrote: >> This patchset is used to support sending rntl info to user in some places, >> and ensure that whenever those attributes change internally or from sysfs, >> that a netlink notification is sent out to listeners. >> >> It also make some adjustment in bridge sysfs so that we can implement this >> easily. >> >> I've done some tests on this patchset, like: >> [br_sysfs] >> 1. change all the attribute values of br or brif: >> $ echo $value > /sys/class/net/br0/bridge/{*} >> $ echo $value > /sys/class/net/br0/brif/eth1/{*} >> >> 2. meanwhile, on another terminal to observe the msg: >> $ bridge monitor >> >> [br_ioctl] >> 1. in bridge-utils package, do some changes in br_set, let brctl command >> use ioctl to set attribute: >> if ((ret = set_sysfs(path, value)) < 0) { --> >> if (1) { >> >> $ brctl set* >> >> 2. meanwhile, on another terminal to observe the msg: >> $ bridge monitor >> >> This test covers all the attributes that brctl and sysfs support to set. >> > > Please also include the bridge maintainers (CCed). >okay, I will post v2 with CC maintainers. thanks