Eric Blake
2023-Aug-11 20:54 UTC
[Libguestfs] [libnbd PATCH v5 00/12] Rust Bindings for Libnbd
On Thu, Aug 03, 2023 at 03:36:04PM +0000, Tage Johansson wrote:> A new version of the Rust bindings for Libnbd. Most changes have been > mentioned as replies to the comments I got on v4. But the most significant > change is probably that the patches have been reordered. > > Best regards, > Tage > > > Tage Johansson (12): > rust: create basic Rust bindings > rust: Add a couple of integration tests > rust: Make it possible to run tests with Valgrind > rust: Add some examples > generator: Add information about asynchronous handle calls > generator: Add information about the lifetime of closures > rust: Use more specific closure traits > rust: async: Create an async friendly handle type > generator: Add `modifies_fd` flag to the [call] structure > rust: async: Use the modifies_fd flag to exclude calls > rust: async: Add a couple of integration tests > rust: async: Add an example > > .gitignore | 10 + > .ocamlformat | 4 + > Makefile.am | 2 + > configure.ac | 30 + > generator/API.ml | 84 ++...> rust/tests/test_log/mod.rs | 86 ++ > rustfmt.toml | 19 + > scripts/git.orderfile | 12 + > 68 files changed, 4851 insertions(+)None of these touched top-level README.md, which should now list cargo and any other new optional build dependencies that must be installed for enabling Rust bindings. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
Tage Johansson
2023-Aug-14 08:31 UTC
[Libguestfs] [libnbd PATCH v5 00/12] Rust Bindings for Libnbd
On 8/11/2023 10:54 PM, Eric Blake wrote:> On Thu, Aug 03, 2023 at 03:36:04PM +0000, Tage Johansson wrote: >> A new version of the Rust bindings for Libnbd. Most changes have been >> mentioned as replies to the comments I got on v4. But the most significant >> change is probably that the patches have been reordered. >> >> Best regards, >> Tage >> >> >> Tage Johansson (12): >> rust: create basic Rust bindings >> rust: Add a couple of integration tests >> rust: Make it possible to run tests with Valgrind >> rust: Add some examples >> generator: Add information about asynchronous handle calls >> generator: Add information about the lifetime of closures >> rust: Use more specific closure traits >> rust: async: Create an async friendly handle type >> generator: Add `modifies_fd` flag to the [call] structure >> rust: async: Use the modifies_fd flag to exclude calls >> rust: async: Add a couple of integration tests >> rust: async: Add an example >> >> .gitignore | 10 + >> .ocamlformat | 4 + >> Makefile.am | 2 + >> configure.ac | 30 + >> generator/API.ml | 84 ++ > ... >> rust/tests/test_log/mod.rs | 86 ++ >> rustfmt.toml | 19 + >> scripts/git.orderfile | 12 + >> 68 files changed, 4851 insertions(+) > None of these touched top-level README.md, which should now list cargo > and any other new optional build dependencies that must be installed > for enabling Rust bindings.True, I'll add that in an upcoming patch. An unrelated question: Should the patch which adds cargo as an optional build dependency to README be a reply to this message or should I send it as a new thread? I'll send it as a new thread now, but what is the best way to do it? -- Best regards, Tage