Hi,
commit b536c61a6df3 ("m4: Remove test for OCaml Bytes module",
2021-11-09) removed AM_CONDITIONAL([HAVE_BYTES_COMPAT_ML ... from
"m4/guestfs-ocaml.m4". However, in the common submodule,
"mlstdutils/Makefile.am" still contains lines such as:
if HAVE_BYTES_COMPAT_ML
This causes autoreconf in libguestfs to fail with:
common/mlstdutils/Makefile.am:30: error: HAVE_BYTES_COMPAT_ML does not
appear in AM_CONDITIONAL
My libguestfs checkout is current master (commit 4fe8df48a723), with the
matching common submodule checkout (62ccce447228).
Substituting a constant for HAVE_BYTES_COMPAT_ML in the "common"
submodule is not obviously a solution, as guestfs-tools still has
AM_CONDITIONAL([HAVE_BYTES_COMPAT_ML ..., in "configure.ac" (at commit
7fdf82407d36).
For now, so that I can progress with something else, I guess I'll try
checking out libguestfs at an earlier commit than b536c61a6df3.
Thanks,
Laszlo
On Fri, Nov 12, 2021 at 02:50:00PM +0100, Laszlo Ersek wrote:> Hi, > > commit b536c61a6df3 ("m4: Remove test for OCaml Bytes module", > 2021-11-09) removed AM_CONDITIONAL([HAVE_BYTES_COMPAT_ML ... from > "m4/guestfs-ocaml.m4". However, in the common submodule, > "mlstdutils/Makefile.am" still contains lines such as: > > if HAVE_BYTES_COMPAT_ML > > This causes autoreconf in libguestfs to fail with:Ahhhhh, that's not good. Let me fix that very quickly.> common/mlstdutils/Makefile.am:30: error: HAVE_BYTES_COMPAT_ML does not > appear in AM_CONDITIONAL > > My libguestfs checkout is current master (commit 4fe8df48a723), with the > matching common submodule checkout (62ccce447228). > > Substituting a constant for HAVE_BYTES_COMPAT_ML in the "common" > submodule is not obviously a solution, as guestfs-tools still has > AM_CONDITIONAL([HAVE_BYTES_COMPAT_ML ..., in "configure.ac" (at commit > 7fdf82407d36). > > For now, so that I can progress with something else, I guess I'll try > checking out libguestfs at an earlier commit than b536c61a6df3.Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
It should work now with: libguestfs: https://github.com/libguestfs/libguestfs/commit/9fda9110e6a7afc1d418665f8f3538d87b5c8a5b guestfs-tools: https://github.com/rwmjones/guestfs-tools/commit/05946b64f896b334a337f6982033e0e98545207b virt-v2v: https://github.com/libguestfs/virt-v2v/commit/ab55f9432e774d83abe431cdf72b6b8e194fe9ec Common submodule fix was: https://github.com/libguestfs/libguestfs-common/commit/a405dc599e571410b83d145d02705708e1715e94 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW