On Tue, Jun 22, 2021 at 9:20 PM Martin Kletzander <mkletzan at redhat.com> wrote:> > Signed-off-by: Martin Kletzander <mkletzan at redhat.com> > --- > ci/build.sh | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ci/build.sh b/ci/build.sh > index 7d62a84a5d4b..4ea3fec7d512 100755 > --- a/ci/build.sh > +++ b/ci/build.sh > @@ -8,6 +8,7 @@ main() { > autoreconf -if > > CONFIG_ARGS="\ > +--enable-python-code-style \I think this is intentionally optional since the version of flake8 or installed plugins can cause build failures. See: https://mail.google.com/mail/u/0/#inbox Python code style should not be part of the build. This is should be used in CI environment or by developers locally, but not when building packages (in case this script is used for building packages). To enable flake8 (and similar tools) the build environment must enforce specific version of the tool. Otherwise you may get unexpected failures when flake8 folks change the rules from version to version. We solve this in ovirt using tox, installing a specific version of flake8: https://github.com/oVirt/vdsm/blob/d7057084fe51dc26811c1ec0ee738ad2314e90fd/tox.ini#L147 https://github.com/oVirt/ovirt-imageio/blob/master/daemon/tox.ini#L26> --enable-gcc-warnings \ > --enable-fuse \ > --enable-ocaml \ > -- > 2.32.0 > > _______________________________________________ > Libguestfs mailing list > Libguestfs at redhat.com > https://listman.redhat.com/mailman/listinfo/libguestfs >
Martin Kletzander
2021-Jun-23 12:56 UTC
[Libguestfs] [libnbd PATCH] ci: Enable python code style
On Tue, Jun 22, 2021 at 10:36:54PM +0300, Nir Soffer wrote:>On Tue, Jun 22, 2021 at 9:20 PM Martin Kletzander <mkletzan at redhat.com> wrote: >> >> Signed-off-by: Martin Kletzander <mkletzan at redhat.com> >> --- >> ci/build.sh | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/ci/build.sh b/ci/build.sh >> index 7d62a84a5d4b..4ea3fec7d512 100755 >> --- a/ci/build.sh >> +++ b/ci/build.sh >> @@ -8,6 +8,7 @@ main() { >> autoreconf -if >> >> CONFIG_ARGS="\ >> +--enable-python-code-style \ > >I think this is intentionally optional since the version of flake8 >or installed plugins can cause build failures. > >See: >https://mail.google.com/mail/u/0/#inbox >I guess that was a masked link =)>Python code style should not be part of the build. This is should >be used in CI environment or by developers locally, but not when >building packages (in case this script is used for building packages). >It is not for building a package, it is a script used in CI and possibly being used by developers to check the status of their worktree, locally or in a container.>To enable flake8 (and similar tools) the build environment must enforce >specific version of the tool. Otherwise you may get unexpected failures >when flake8 folks change the rules from version to version. > >We solve this in ovirt using tox, installing a specific version of flake8: >https://github.com/oVirt/vdsm/blob/d7057084fe51dc26811c1ec0ee738ad2314e90fd/tox.ini#L147 >https://github.com/oVirt/ovirt-imageio/blob/master/daemon/tox.ini#L26 >I see. I was just reacting to the e-mail from Rich where he showed how he checks the package before release. I do not think he pins it to a specific version. You can do that when installing from pip, e.g. in a virtualenv, but not when just checking locally with a distro-provided package (at least not on binary distributions that do not offer older package versions). Anyway, it was just a quick reaction, we can keep it like it is and improve upon it later on. I just distracted myself from other, more important things anyway =)>> --enable-gcc-warnings \ >> --enable-fuse \ >> --enable-ocaml \ >> -- >> 2.32.0 >> >> _______________________________________________ >> Libguestfs mailing list >> Libguestfs at redhat.com >> https://listman.redhat.com/mailman/listinfo/libguestfs >> >-------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://listman.redhat.com/archives/libguestfs/attachments/20210623/84c3716f/attachment.sig>