Libguestfs - Oct 2013 - Re: [PATCH] * supermin support for FrugalWare (pacman-g2)

Hi,

(added myself as CC as I'm not subscribed to this MailingList curently)

I already sent a pull request via github, but was told that review via ML
is preferred.

Another patch for libguestfs will follow in a seperate Mail.

Greetings
Daniel

On Tue, Oct 22, 2013 at 08:42:12PM +0200, Daniel Exner
wrote:
> -dnl For ArchLinux handler.
> -AC_CHECK_PROG(PACMAN,[pacman],[pacman],[no])
> +dnl For FrugalWare handler.
> +AC_CHECK_PROG(PACMAN_G2,[pacman-g2],[pacman-g2],[no])
> +
> +dnl if test "x$pacman_g2" = "xno"; then
> +dnl	dnl For ArchLinux handler.
> +dnl	AC_CHECK_PROG(PACMAN,[pacman],[pacman],[no])
> +dnl fi
> +
This seems to disable the ArchLinux (ie. pacman) driver.
Is that intentional?  It seems wrong to me.

The rest of the patch is fine.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Richard W.M. Jones:
> On Tue, Oct 22, 2013 at 08:42:12PM +0200, Daniel Exner wrote:
>> -dnl For ArchLinux handler. 
>> -AC_CHECK_PROG(PACMAN,[pacman],[pacman],[no]) +dnl For FrugalWare
>> handler. +AC_CHECK_PROG(PACMAN_G2,[pacman-g2],[pacman-g2],[no]) 
>> + +dnl if test "x$pacman_g2" = "xno"; then +dnl	dnl
For ArchLinux
>> handler. +dnl	AC_CHECK_PROG(PACMAN,[pacman],[pacman],[no]) +dnl
>> fi +
> 
> This seems to disable the ArchLinux (ie. pacman) driver. Is that
> intentional?  It seems wrong to me.
Oh, of course you are right.
I commented this to check the logic and forgot to uncomment it again. :(

I attached another patch to fix this.

Greetings
Daniel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSaBklAAoJEFr5300M52i8ORAQAIIk56NWfkoVDl4z8ceYHVcm
0D3YuKRXXOJxdkw9yLoBH5Q+7unO6pB/slrYVzK9DHTp7VpXiYvg2MPQp2Y6ps3O
1bJyI2VmwODg9/wTyANOxThAi4RG7ISdoL5ph385r/CVfneJcfkuh/kKpruxjqKY
QgKMq3ACTDK3y7KgWN/dOjQYyQSgl6+AHuT8lO5ca/0AQOFO3BNIpIHKdzKtzM2g
008RZfOSSk1HVy7wkxa8HFfEy9S5QGxj+iQl5jA9kh1xy1Xq1drxDgmAyL6jjqJ1
ur7hnXuX91ld4Y8UjbGsxdoDzUGdzpbpsKmdrrMlgYFt5pZorskB1g040Gyrdx77
oNqmu+ZwptwyMN1H0xCfqrZ8IFHWjw+MD+5c2hXjWCCfNysVOdBkclCF9XI+euH+
kAXnx9IfoTWOJCe9pv2DPGyOu7FVyVYH491Hqu1AVFRjvz7YLJf6dMyXnT/3mAIu
0ZIQr2GHyZ3nx67t3ZuY6BoXd7wMiZN/Q65e6q3vF7hSts790CS3o3zOg4pA/dZF
5D4Sg9bintry/GtEqZPBMSxM8wKidhNIr45Pb5pNHFwyGA7yiGhEy61j7K5E1J7e
8cazvnorD4kuYn/uwsv9puWvw9C6eUSBo+n4rTauVnTZWQuAoRkzob91L9kJpoG4
dT3DibX1HGuyZwgIttIL
=TPCZ
-----END PGP SIGNATURE-----

On Tue, Oct 22, 2013 at 08:42:12PM +0200, Daniel Exner
wrote:
> Hi,
> 
> (added myself as CC as I'm not subscribed to this MailingList curently)
> 
> I already sent a pull request via github, but was told that review via ML
> is preferred.
> 
> Another patch for libguestfs will follow in a seperate Mail.
Thanks, I have pushed this, with some whitespace changes and
uncommenting the ArchLinux test as discussed.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/