Libguestfs - Sep 2009 - [PATCH] Don't enable trace in set_trace test.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into Xen guests.
http://et.redhat.com/~rjones/virt-p2v
-------------- next part --------------
>From 4a3d4323745a4222adf4377d62c0c66a1b80d0fc Mon Sep 17 00:00:00 2001
From: Richard Jones <rjones at trick.home.annexia.org>
Date: Mon, 14 Sep 2009 16:21:04 +0100
Subject: [PATCH] Don't enable trace in set_trace test.

This leaves trace enabled afterwards, resulting in some
ugly test messages.
---
 src/generator.ml |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/generator.ml b/src/generator.ml
index 50a41c7..179665b 100755
--- a/src/generator.ml
+++ b/src/generator.ml
@@ -778,8 +778,8 @@ For more information on the architecture of libguestfs,
 see L<guestfs(3)>.");
 
   ("set_trace", (RErr, [Bool "trace"]), -1, [FishAlias
"trace"],
-   [InitNone, Always, TestOutputTrue (
-      [["set_trace"; "true"];
+   [InitNone, Always, TestOutputFalse (
+      [["set_trace"; "false"];
        ["get_trace"]])],
    "enable or disable command traces",
    "\
-- 
1.6.2.5

On 14/09/09 16:22, Richard W.M. Jones wrote:
>
>> From 4a3d4323745a4222adf4377d62c0c66a1b80d0fc Mon Sep 17 00:00:00 2001
> From: Richard Jones<rjones at trick.home.annexia.org>
> Date: Mon, 14 Sep 2009 16:21:04 +0100
> Subject: [PATCH] Don't enable trace in set_trace test.
>
> This leaves trace enabled afterwards, resulting in some
> ugly test messages.
> ---
>   src/generator.ml |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/generator.ml b/src/generator.ml
> index 50a41c7..179665b 100755
> --- a/src/generator.ml
> +++ b/src/generator.ml
> @@ -778,8 +778,8 @@ For more information on the architecture of libguestfs,
>   see L<guestfs(3)>.");
>
>     ("set_trace", (RErr, [Bool "trace"]), -1,
[FishAlias "trace"],
> -   [InitNone, Always, TestOutputTrue (
> -      [["set_trace"; "true"];
> +   [InitNone, Always, TestOutputFalse (
> +      [["set_trace"; "false"];
>          ["get_trace"]])],
>      "enable or disable command traces",
>      "\
> -- 1.6.2.5
ACK

-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490