The path of the linker script on mips is not correct: tbm@raq2:~/tmp/src/klibc-1.1.14$ make KLIBCLD klibc/libc.so ld: cannot open linker script file arch/mips/klibc.ld: No such file or directory diff -urN klibc-1.1.16~/klibc/arch/mips/MCONFIG klibc-1.1.16/klibc/arch/mips/MCONFIG --- klibc-1.1.16~/klibc/arch/mips/MCONFIG 2006-01-06 06:11:43.000000000 +0000 +++ klibc-1.1.16/klibc/arch/mips/MCONFIG 2006-01-08 16:35:58.000000000 +0000 @@ -12,4 +12,4 @@ BITSIZE = 32 # Extra linkflags when building the shared version of the library -SHAREDFLAGS = -T arch/$(ARCH)/klibc.ld +SHAREDFLAGS = -T klibc/arch/$(ARCH)/klibc.ld -- Martin Michlmayr http://www.cyrius.com/
On Sun, Jan 08, 2006 at 06:59:32PM +0000, Martin Michlmayr wrote:> The path of the linker script on mips is not correct: > > tbm@raq2:~/tmp/src/klibc-1.1.14$ make > KLIBCLD klibc/libc.so > ld: cannot open linker script file arch/mips/klibc.ld: No such file or directory > > > diff -urN klibc-1.1.16~/klibc/arch/mips/MCONFIG klibc-1.1.16/klibc/arch/mips/MCONFIG > --- klibc-1.1.16~/klibc/arch/mips/MCONFIG 2006-01-06 06:11:43.000000000 +0000 > +++ klibc-1.1.16/klibc/arch/mips/MCONFIG 2006-01-08 16:35:58.000000000 +0000 > @@ -12,4 +12,4 @@ > BITSIZE = 32 > > # Extra linkflags when building the shared version of the library > -SHAREDFLAGS = -T arch/$(ARCH)/klibc.ld > +SHAREDFLAGS = -T klibc/arch/$(ARCH)/klibc.ldIf you use $(src) the change will work in both trees - like this:> +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ldWe like klibc to be buildable both as standalone and in the kernel. Untested - so please test before resubmit... Sam
* Sam Ravnborg <sam@ravnborg.org> [2006-01-08 20:15]:> If you use $(src) the change will work in both trees - like this: > > +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ld > > We like klibc to be buildable both as standalone and in the kernel. > Untested - so please test before resubmit...Tested - works, thanks. diff -urN klibc-1.1.16~/klibc/arch/mips/MCONFIG klibc-1.1.16/klibc/arch/mips/MCONFIG --- klibc-1.1.16~/klibc/arch/mips/MCONFIG 2006-01-06 06:11:43.000000000 +0000 +++ klibc-1.1.16/klibc/arch/mips/MCONFIG 2006-01-08 19:49:57.000000000 +0000 @@ -12,4 +12,4 @@ BITSIZE = 32 # Extra linkflags when building the shared version of the library -SHAREDFLAGS = -T arch/$(ARCH)/klibc.ld +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ld -- Martin Michlmayr http://www.cyrius.com/
On Sun, Jan 08, 2006 at 07:50:33PM +0000, Martin Michlmayr wrote:> * Sam Ravnborg <sam@ravnborg.org> [2006-01-08 20:15]: > > If you use $(src) the change will work in both trees - like this: > > > +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ld > > > > We like klibc to be buildable both as standalone and in the kernel. > > Untested - so please test before resubmit... > > Tested - works, thanks.Hi Martin. As a nice path submitter you should repeat the changelog entry so it is trivial for hpa to apply your patch. With this mail hpa has to go back and pick the old changelog entry in another mail and manually add it to your mail. Compare that to a situation where hpa only have to delete say 15 lines of irrelevant text. Not a big deal for a single patch, but with current patch flood for klibc I bet it matters for hpa. Sam> > > diff -urN klibc-1.1.16~/klibc/arch/mips/MCONFIG klibc-1.1.16/klibc/arch/mips/MCONFIG > --- klibc-1.1.16~/klibc/arch/mips/MCONFIG 2006-01-06 06:11:43.000000000 +0000 > +++ klibc-1.1.16/klibc/arch/mips/MCONFIG 2006-01-08 19:49:57.000000000 +0000 > @@ -12,4 +12,4 @@ > BITSIZE = 32 > > # Extra linkflags when building the shared version of the library > -SHAREDFLAGS = -T arch/$(ARCH)/klibc.ld > +SHAREDFLAGS = -T $(src)/arch/$(ARCH)/klibc.ld > > -- > Martin Michlmayr > http://www.cyrius.com/