On Tuesday 21 January 2003 10:38, Michael Smith shaped the electrons to shout:> This is much improved. There are a few things to clean up (comments, > for instance, since we're not targetting C99), plus actually writing > the generic implementation for get_predata() (which at the moment only > mp3 will use), but the design looks fine. I'm unlikely to have time toHope you read this message before leaving the country... In order to implement a generic get_data function, which has to check for teh faststart_queue, and other fields, I must move the following fields: long faststart_size; /* If > 0, max bytes in queue */ refbuf_queue_t *faststart_queue; long faststart_queue_size; /* In bytes */ from the _state structure (which differs according to the format) to format_plugin_t. If don't agree tell me as soon as you can please. <p> -- ricardo galli GPG id C8114D34 --- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
> Hope you read this message before leaving the country... > > In order to implement a generic get_data function, which has to check for > teh faststart_queue, and other fields, I must move the following fields: > > long faststart_size; /* If > 0, max bytes in queue */ > refbuf_queue_t *faststart_queue; > long faststart_queue_size; /* In bytes */ > > from the _state structure (which differs according to the format) to > format_plugin_t. > > If don't agree tell me as soon as you can please.That's fine, except faststart_size, which can stay in the config struct, it doesn't need another local copy here. Mike <p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thursday 23 January 2003 11:44, Michael Smith shaped the electrons to shout:> > Hope you read this message before leaving the country... > > > > In order to implement a generic get_data function, which has to check > > for teh faststart_queue, and other fields, I must move the following > > fields: > > > > long faststart_size; /* If > 0, max bytes in queue */ > > refbuf_queue_t *faststart_queue; > > long faststart_queue_size; /* In bytes */ > > > > from the _state structure (which differs according to the format) to > > format_plugin_t. > > > > If don't agree tell me as soon as you can please. > > That's fine, except faststart_size, which can stay in the config > struct, it doesn't need another local copy here.OK, thanks. Find enclosed the patch thats implements it. Regards, - -- ricardo galli GPG id C8114D34 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+MGypXZ2eFsgRTTQRAjtWAJ4vYimhnuR63l+uzA00OIozHcI/vgCgowyt Hp81DWai2FEc77Frlk3oGsY=sNn+ -----END PGP SIGNATURE----- -------------- next part -------------- A non-text attachment was scrubbed... Name: update2a.diff Type: text/x-diff Size: 10057 bytes Desc: update2a.diff Url : http://lists.xiph.org/pipermail/icecast-dev/attachments/20030123/f2fbd5df/update2a.bin