Resubmission of patches with curteous nods from the MusicKit Project... - SKoT ----- Original Message ----- From: "Stephen Brandon" <stephen@brandonitconsulting.co.uk> To: <icecast-dev@xiph.org> Sent: Wednesday, January 16, 2002 1:26 PM Subject: [icecast-dev] Some diffs to libshout for MacOSX <p>> Hi,> > I'm part of a project developing the open source SndKit and MusicKit,which> are ObjC frameworks originally from NeXTSTEP, but now on MacOSX andGNUstep.> > We use libshout.a in part of the SndKit to enable us to schedule andprocess> audio to get sent to shoutcast/icecast servers - pretty cool. > > Anyway, when compiling libshout on MacOSX it fails because it does nothave> sys/poll.h, but uses select() instead of poll(). > > I have therefore made some changes/additions to libshout/configure.in to > autodetect the presence of sys/poll.h. In sock.c, I use #ifdef statementsto> then use the select() or poll() behaviour depending on the presence of the > sys/poll.h header. > > I have attached 2 diff files: one for configure.in, and one for sock.c. > > I hope that these meet with your approval -- and if so, could you pleaseput> them into your CVS ASAP, because we are now starting to rely on libshout.a > for all our developers/users, and it's a pain to compile on MacOSX without > these changes. > > ps I got hold of libshout via the ices 0.2.2 source package. Is libshout > going to remain as a part of that package? > > Cheers, > Stephen Brandon > stephen@brandonitconsulting.co.uk >-------------- next part -------------- A non-text attachment was scrubbed... Name: configure.in.diff Type: application/octet-stream Size: 723 bytes Desc: configure.in.diff Url : http://lists.xiph.org/pipermail/icecast-dev/attachments/20020204/0d6e326c/configure.in.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: sock.c.diff Type: application/octet-stream Size: 1064 bytes Desc: sock.c.diff Url : http://lists.xiph.org/pipermail/icecast-dev/attachments/20020204/0d6e326c/sock.c.obj
Brendan, Thanks for applying these patches - that's great. We're about to release the latest version of our SndKit frameworks, which require libshout to be installed in order to compile. Up until now we have provided the set of patches that we sent to you, and instructed people to download the iceS-0.2.2 package, apply the patches, and compile from there. What we'd prefer though is to be able to point people to a tarball with the authoritative source code, and not have to apply patches or even use CVS to get the package. So, what we've decided to do is to ask you if you could please make a tarball of the ices/libshout package as you have done before, as release 0.2.3, or alternatively to just tag libshout in CVS, and put the tarball on your website as a standalone bundle as you did with the much older version (0.1.0 if I remember correctly). [It's only libshout that is required for our work] I suppose the latter would be easiest to do - do you think you would be able to make a tarball and put it up on your ftp site, with a link from the icecast web pages, in the next day or two? On behalf of the MusicKit/SndKit team, Yours, Stephen Brandon stephen@brandonitconsulting.co.uk PS if possible, it would be great if you could also apply the other MinGW patches I sent the other day! PPS sorry, I nearly forgot to add - in libshout/shout.h, in the prototype for the shout_strerror() function, you use the word "namespace" as an argument identifier. Some of our users who are using this in C++ projects report that this use of a reserved word causes a compiler error when the header is imported. Could you please also just change this use of the keyword to an alternative? It will of course cause no side effects. Thanks! char *shout_strerror(shout_conn_t *self, int error, char *namespace, int maxlen); <p>On Friday 08 Feb 2002 3:28 pm, you wrote:> I've applied this, with the difference that the select timeout is 30 > seconds to match the poll timeout. It looks like libshout treats a > timeout as a fatal error? > > On Monday, 04 February 2002 at 08:32, SKoT McDonald wrote: > > Resubmission of patches with curteous nods from the MusicKit Project... > > > > - SKoT--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
I've applied this, with the difference that the select timeout is 30 seconds to match the poll timeout. It looks like libshout treats a timeout as a fatal error? On Monday, 04 February 2002 at 08:32, SKoT McDonald wrote:> Resubmission of patches with curteous nods from the MusicKit Project... > > - SKoT > > ----- Original Message ----- > From: "Stephen Brandon" <stephen@brandonitconsulting.co.uk> > To: <icecast-dev@xiph.org> > Sent: Wednesday, January 16, 2002 1:26 PM > Subject: [icecast-dev] Some diffs to libshout for MacOSX > > > > Hi, > > > > I'm part of a project developing the open source SndKit and MusicKit, > which > > are ObjC frameworks originally from NeXTSTEP, but now on MacOSX and > GNUstep. > > > > We use libshout.a in part of the SndKit to enable us to schedule and > process > > audio to get sent to shoutcast/icecast servers - pretty cool. > > > > Anyway, when compiling libshout on MacOSX it fails because it does not > have > > sys/poll.h, but uses select() instead of poll(). > > > > I have therefore made some changes/additions to libshout/configure.in to > > autodetect the presence of sys/poll.h. In sock.c, I use #ifdef statements > to > > then use the select() or poll() behaviour depending on the presence of the > > sys/poll.h header. > > > > I have attached 2 diff files: one for configure.in, and one for sock.c. > > > > I hope that these meet with your approval -- and if so, could you please > put > > them into your CVS ASAP, because we are now starting to rely on libshout.a > > for all our developers/users, and it's a pain to compile on MacOSX without > > these changes. > > > > ps I got hold of libshout via the ices 0.2.2 source package. Is libshout > > going to remain as a part of that package? > > > > Cheers, > > Stephen Brandon > > stephen@brandonitconsulting.co.uk > ><p><p><p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.