freebsd stable - Apr 2007 - make: parallel jobs broken when using -f -

Hi Hartmut,

there is an annoying bug in 6-STABLE make(1), where -f - seems to
serialize the target making.

Consider the following Makefile

all: a b c d

a b c d:
        @echo Makeing ${.TARGET}
        @sleep 4

And observe the following behaviour:
$ make -j4
Makeing a
Makeing b
Makeing c
Makeing d
  <pause>
$ make -j4 -f- < Makefile
Makeing b
Makeing d
  <pause>
Makeing a
  <pause>
Makeing c
  <pause>
$

The make(1) on -CURRENT has this fixed already, is there any chance of
this getting MFCed?

AFAICS the following revisions are not up to date (wrt to CURRENT):
     $FreeBSD: src/usr.bin/make/job.c,v 1.122.2.1 2005/07/20 19:05:23 harti Exp
$
     $FreeBSD: src/usr.bin/make/main.c,v 1.155 2005/05/24 16:05:51 harti Exp $
     $FreeBSD: src/usr.bin/make/parse.c,v 1.108.2.1 2005/11/16 08:25:19 ru Exp $
     $FreeBSD: src/usr.bin/make/str.c,v 1.45.2.1 2006/10/16 11:51:18 ru Exp $
     $FreeBSD: src/usr.bin/make/var.c,v 1.159 2005/05/24 16:05:51 harti Exp $


Ulrich Spoerlein
-- 
"The trouble with the dictionary is you have to know how the word is
spelled before you can look it up to see how it is spelled."
-- Will Cuppy

Hi Ulrich,

On Thu, Apr 12, 2007 at 11:24:04PM +0200, Ulrich Spoerlein
wrote:
> there is an annoying bug in 6-STABLE make(1), where -f - seems to
> serialize the target making.
> 
> Consider the following Makefile
> 
> all: a b c d
> 
> a b c d:
>         @echo Makeing ${.TARGET}
>         @sleep 4
> 
> And observe the following behaviour:
> $ make -j4
> Makeing a
> Makeing b
> Makeing c
> Makeing d
>   <pause>
> $ make -j4 -f- < Makefile
> Makeing b
> Makeing d
>   <pause>
> Makeing a
>   <pause>
> Makeing c
>   <pause>
> $
> 
> The make(1) on -CURRENT has this fixed already, is there any chance of
> this getting MFCed?
> 
> AFAICS the following revisions are not up to date (wrt to CURRENT):
>      $FreeBSD: src/usr.bin/make/job.c,v 1.122.2.1 2005/07/20 19:05:23 harti
Exp $
>      $FreeBSD: src/usr.bin/make/main.c,v 1.155 2005/05/24 16:05:51 harti
Exp $
>      $FreeBSD: src/usr.bin/make/parse.c,v 1.108.2.1 2005/11/16 08:25:19 ru
Exp $
>      $FreeBSD: src/usr.bin/make/str.c,v 1.45.2.1 2006/10/16 11:51:18 ru Exp
$
>      $FreeBSD: src/usr.bin/make/var.c,v 1.159 2005/05/24 16:05:51 harti Exp
$
> 
The bug you're seeing is PR bin/101232.  Please query
Will Andrews about the MFC, or if he doesn't reply in
a timely manner, ping me and I'll commit it for you.


Cheers,
-- 
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url :
http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20070413/c7f4b7b5/attachment.pgp