flac dev - Jun 2017 - [PATCH] doc: Add notes about subframe sample size

>> I'm jumping in on this thread to make a few remarks about the spec.
I
>> implemented a FLAC decoder by only looking at the spec, and I have a
few
>> notes that would have saved me a lot of time if the spec had mentioned
>> them. They are obvious in hindsight, of course.
>>
>> * If the channel assignment includes a difference channel, then the
>> subframe for that channel has one extra bit per sample in order to
>> encode the difference.
>>
>> * The number of bits per sample for a subframe, is the number of bits
>> per sample of the frame, minus the number of wasted bits per sample of
>> the subframe (and possibly plus one for a difference channel).
>>
>> I hope this helps future implementers.
> 
> I would love to see a patch against the documentation for this.
> 
> Erik
Here you go.

Kind regards,

Ruud van Asseldonk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-doc-Add-notes-about-subframe-sample-size.patch
Type: text/x-patch
Size: 1519 bytes
Desc: not available
URL:
<http://lists.xiph.org/pipermail/flac-dev/attachments/20170611/293504db/attachment.bin>

Hi Ruud van Asseldonk,
> On Jun 11, 2017, at 7:24 AM, Ruud van Asseldonk <dev at
veniogames.com> wrote:
> 
>>> I'm jumping in on this thread to make a few remarks about the
spec. I
>>> implemented a FLAC decoder by only looking at the spec, and I have
a few
>>> notes that would have saved me a lot of time if the spec had
mentioned
>>> them. They are obvious in hindsight, of course.
>>> 
>>> * If the channel assignment includes a difference channel, then the
>>> subframe for that channel has one extra bit per sample in order to
>>> encode the difference.
>>> 
>>> * The number of bits per sample for a subframe, is the number of
bits
>>> per sample of the frame, minus the number of wasted bits per sample
of
>>> the subframe (and possibly plus one for a difference channel).
>>> 
>>> I hope this helps future implementers.
>> 
>> I would love to see a patch against the documentation for this.
>> 
>> Erik
> 
> Here you go.
> 
> Kind regards,
> 
> Ruud van Asseldonk
>
<0001-doc-Add-notes-about-subframe-sample-size.patch>_______________________________________________
Do you mind to submit this patch as well to cellar at ietf.org <mailto:cellar
at ietf.org> (info at https://www.ietf.org/mailman/listinfo/cellar
<https://www.ietf.org/mailman/listinfo/cellar>). That working group is
currently working on the Flac format documentation in
https://github.com/privatezero/flac_markdown
<https://github.com/privatezero/flac_markdown> and
https://datatracker.ietf.org/wg/cellar/documents/
<https://datatracker.ietf.org/wg/cellar/documents/>.
Dave Rice

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.xiph.org/pipermail/flac-dev/attachments/20170611/1d9cecff/attachment.html>

Ruud van Asseldonk wrote:
>I hope this helps future implementers.
Thank you very much, Ruud! I posted our advice on GitHub:

  https://github.com/privatezero/flac_markdown/issues/53

Best regards, Reto

Ruud van Asseldonk wrote:
> Here you go.
Wonderful. Thank you!

Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/