Ozkan Sezer
2017-Jan-13 15:36 UTC
[flac-dev] unsigned int and FLAC__uint32 are used interchangeably
unsigned int and FLAC__uint32 are used interchangeably, leading to warnings with platforms (e.g. djgpp) where int32_t is long: bitreader.c: In function `FLAC__bitreader_read_rice_signed': bitreader.c:721: warning: passing arg 2 of `FLAC__bitreader_read_unary_unsigned' from incompatible pointer type bitreader.c: In function `FLAC__bitreader_read_rice_signed_block': bitreader.c:850: warning: passing arg 2 of `FLAC__bitreader_read_raw_uint32' from incompatible pointer type stream_decoder.c: In function `read_residual_partitioned_rice_': stream_decoder.c:2774: warning: passing arg 2 of `FLAC__bitreader_read_rice_signed_block' from incompatible pointer type stream_decoder.c:2783: warning: passing arg 2 of `FLAC__bitreader_read_raw_int32' from incompatible pointer type Apart from that, this also leads to format string warnings, e.g.: bitwriter.c:222: warning: unsigned int format, long unsigned int arg (arg 2) [many more, and in several sources.] This is just a FYI report. I don't have a patch for it. -- O.S.
Erik de Castro Lopo
2017-Jan-14 06:35 UTC
[flac-dev] unsigned int and FLAC__uint32 are used interchangeably
Ozkan Sezer wrote:> unsigned int and FLAC__uint32 are used interchangeably, leading to > warnings with platforms (e.g. djgpp) where int32_t is long:Is `sizeof int == 4` though? I couldn't image FLAC working correctly if it wasn't. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Ozkan Sezer
2017-Jan-14 07:10 UTC
[flac-dev] unsigned int and FLAC__uint32 are used interchangeably
On 1/14/17, Erik de Castro Lopo <mle+la at mega-nerd.com> wrote:> Ozkan Sezer wrote: > >> unsigned int and FLAC__uint32 are used interchangeably, leading to >> warnings with platforms (e.g. djgpp) where int32_t is long: > > Is `sizeof int == 4` though?Yes, obviously it is> I couldn't image FLAC working correctly > if it wasn't. > > Erik