1) The definition of FLAC__BitWriter was updated with the current text from /libFLAC/bitwriter.c (the text in comments was changed). And the definition of TOTAL_BITS was made closer to the code from /libFLAC/bitwriter.c. 2) The values for 'words' and 'bits' values now calculated, not just some magic constants. 3) Added FLAC__U64L() for 64-bit constants. It seems that it isn't necessary (the values of these constants are less than 2^32), but IMHO the code looks better with FLAC__U64L. -------------- next part -------------- A non-text attachment was scrubbed... Name: 4_test_bitwriter.patch Type: application/octet-stream Size: 6375 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20151228/30077a52/attachment.obj
Erik de Castro Lopo
2015-Dec-31 08:18 UTC
[flac-dev] [PATCH 4] for test_libFLAC/bitwriter.c
lvqcl wrote:> 1) The definition of FLAC__BitWriter was updated with the > current text from /libFLAC/bitwriter.c (the text in comments was changed). > And the definition of TOTAL_BITS was made closer to the code from /libFLAC/bitwriter.c. > > > 2) The values for 'words' and 'bits' values now calculated, not just some > magic constants. > > > 3) Added FLAC__U64L() for 64-bit constants. It seems that it isn't > necessary (the values of these constants are less than 2^32), but > IMHO the code looks better with FLAC__U64L.Applied. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/