Erik de Castro Lopo
2015-Apr-10 21:10 UTC
[flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
Tristan Matthews wrote:> --- > configure.ac | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index eb9b0cc..e7d68c3 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then > > if test "x$asm_optimisation$sse_os" = "xyesyes" ; then > XIPH_ADD_CFLAGS([-msse2]) > - XIPH_ADD_CFLAGS([-mstackrealign]) > fi > + fi > > +if test "$host_os" = "mingw32" ; then > + XIPH_ADD_CFLAGS([-mstackrealign]) > fi > > XIPH_ADD_CFLAGS([-Wextra])Everyone happy with this patch? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Dave Yeo
2015-Apr-10 22:59 UTC
[flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
On 04/10/15 02:10 pm, Erik de Castro Lopo wrote:> Tristan Matthews wrote: > >> --- >> configure.ac | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index eb9b0cc..e7d68c3 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then >> >> if test "x$asm_optimisation$sse_os" = "xyesyes" ; then >> XIPH_ADD_CFLAGS([-msse2]) >> - XIPH_ADD_CFLAGS([-mstackrealign]) >> fi >> + fi >> >> +if test "$host_os" = "mingw32" ; then >> + XIPH_ADD_CFLAGS([-mstackrealign]) >> fi >> >> XIPH_ADD_CFLAGS([-Wextra]) > > Everyone happy with this patch? >Should it be a case statement so other OSes can be added or just use || ? OS/2 should also have the -mstackrealign option added as well. Dave
JonY
2015-Apr-10 23:16 UTC
[flac-dev] [PATCH] configure: only use -mstackrealign for mingw32
On 4/11/2015 05:10, Erik de Castro Lopo wrote:> Tristan Matthews wrote: > >> --- >> configure.ac | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/configure.ac b/configure.ac >> index eb9b0cc..e7d68c3 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -399,9 +399,11 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then >> >> if test "x$asm_optimisation$sse_os" = "xyesyes" ; then >> XIPH_ADD_CFLAGS([-msse2]) >> - XIPH_ADD_CFLAGS([-mstackrealign]) >> fi >> + fi >> >> +if test "$host_os" = "mingw32" ; then >> + XIPH_ADD_CFLAGS([-mstackrealign]) >> fi >> >> XIPH_ADD_CFLAGS([-Wextra]) > > Everyone happy with this patch? > > Erik >This should only apply to i686 host 32bit mingw. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20150411/d89d8280/attachment.pgp
Tristan Matthews
2015-Apr-11 05:00 UTC
[flac-dev] [PATCH] configure: only use -mstackrealign on mingw32/os2
And only for i686. --- configure.ac | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index eb9b0cc..8dd5b0d 100644 --- a/configure.ac +++ b/configure.ac @@ -399,11 +399,16 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then if test "x$asm_optimisation$sse_os" = "xyesyes" ; then XIPH_ADD_CFLAGS([-msse2]) - XIPH_ADD_CFLAGS([-mstackrealign]) fi - fi +case "$host_os" in + "mingw32"|"os2") + if test "$host_cpu" = "i686"; then + XIPH_ADD_CFLAGS([-mstackrealign]) + fi +esac + XIPH_ADD_CFLAGS([-Wextra]) if test x$enable_werror = "xyes" ; then -- 2.1.0