lvqcl wrote:> lvqcl wrote: > > > 1) in config.h FLAC__HAS_X86INTRIN macro is always defined and empty, > > even if x86intrin.h is not available. > > > > 2) sse_os is defined as 'yes' or 'no', but AM_CONDITIONAL tests it for 'true': > > The patch is attached. Please check it.Looks good. I need to do a little testing.> > 3) configure --disable-sse prints: > > " SSE optimizations : ................... no" > > but this option actually doesn't disable SSE, so this message > > is a bit misleading. > > Instead of the current message > > echo " SSE optimizations : ................... ${sse_os}" > > it's technically more correct to write: > > echo " OS is guaranteed to support SSE : ..... ${sse_os}" > > but this message is much less comprehensible.This is also a little misleading as its not the OS we are checking for SSE support but the compiler. I'll fix this. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Erik de Castro Lopo wrote:> This is also a little misleading as its not the OS we are checking > for SSE support but the compiler. I'll fix this.How so? ./configure script tests a compiler by checking the existence of x86intrin.h. If the file exist then it is assumed that a compiler supports SSE intrinsics. --enable-sse results in a definition of FLAC__SSE_OS preprocessor variable. If it is defined then SSE detection code in src/libFLAC/cpu.c assumes that OS supports SSE. Otherwise it tries to perform a runtime check (basically, it executes an SSE operation and tries to catch invalid opcode exception).
lvqcl wrote:> How so? ./configure script tests a compiler by checking the existence of x86intrin.h. > If the file exist then it is assumed that a compiler supports SSE intrinsics. > > --enable-sse results in a definition of FLAC__SSE_OS preprocessor variable. > If it is defined then SSE detection code in src/libFLAC/cpu.c > assumes that OS supports SSE.Sow what about just: echo " Compiler is Clang : ................... ${xiph_cv_c_compiler_clang}" - echo " SSE optimizations : ................... ${sse_os}" + echo " SSE enabled : ......................... ${sse_enabled}" echo " Asm optimizations : ................... ${asm_optimisation}" echo " Ogg/FLAC support : .................... ${have_ogg}" Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/