Jaren Stangret
2013-Mar-11 20:41 UTC
[flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Hi all, I'm currently going through the massive test suite, updating all the scripts making sure they conform to the POSIX standard. I've added a bunch of comments to them and have slightly changed/reworked some of the functions to make it easier to read and process. I'm also eliminating the use of 'echo' in favor of 'printf' since echo has many unspecified uses. Attached are only three patches (each patch is for a different test script). If everyone is happy with these three patches, I'll continue and rework the rest of the scripts. Thanks! -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20130311/71c0b1e8/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: test_libFLAC.sh.patch Type: application/octet-stream Size: 2151 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130311/71c0b1e8/attachment-0003.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: test_libFLAC++.sh.patch Type: application/octet-stream Size: 2244 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130311/71c0b1e8/attachment-0004.obj -------------- next part -------------- A non-text attachment was scrubbed... Name: test_seeking.sh.patch Type: application/octet-stream Size: 14839 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130311/71c0b1e8/attachment-0005.obj
Erik de Castro Lopo
2013-Mar-12 04:37 UTC
[flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Jaren Stangret wrote:> Hi all, > > I'm currently going through the massive test suite, updating all the > scripts making sure they conform to the POSIX standard. > > I've added a bunch of comments to them and have slightly changed/reworked > some of the functions to make it easier to read and process. > > I'm also eliminating the use of 'echo' in favor of 'printf' since echo has > many unspecified uses. > > Attached are only three patches (each patch is for a different test > script). If everyone is happy with these three patches, I'll continue and > rework the rest of the scripts.I'd normally say no to a big set of patches like this so close to a final release, but if they only touch tests scripts and when I test them they work on Linux, FreeBSD and OpenBSD, then I'm happy to have them. I'll test this first batch within the next 8-12 hours. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Brian Willoughby
2013-Mar-12 04:51 UTC
[flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
On Mar 11, 2013, at 21:37, Erik de Castro Lopo wrote:> Jaren Stangret wrote: > >> Hi all, >> >> I'm currently going through the massive test suite, updating all the >> scripts making sure they conform to the POSIX standard. >> >> I've added a bunch of comments to them and have slightly changed/ >> reworked >> some of the functions to make it easier to read and process. >> >> I'm also eliminating the use of 'echo' in favor of 'printf' since >> echo has >> many unspecified uses. >> >> Attached are only three patches (each patch is for a different test >> script). If everyone is happy with these three patches, I'll >> continue and >> rework the rest of the scripts. > > I'd normally say no to a big set of patches like this so close to a > final > release, but if they only touch tests scripts and when I test them > they work > on Linux, FreeBSD and OpenBSD, then I'm happy to have them. > > I'll test this first batch within the next 8-12 hours. > > ErikHmm, if this huge patch breaks the tests, how do we know whether 1.3.0 is performing identically to 1.2.1? I'm thinking that there is a possibility that the tests might produce a false positive. It seems safer to only change the library or the tests, but not both at the same time. Maybe the patches to the tests should wait until 1.3.1 Brian Willoughby Sound Consulting
Erik de Castro Lopo
2013-Mar-12 06:44 UTC
[flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Jaren Stangret wrote:> Attached are only three patches (each patch is for a different test > script). If everyone is happy with these three patches, I'll continue and > rework the rest of the scripts.These look good so far. I've commited them to a branch. When I get the rest I'll test them thoroughly as a batch. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Jaren Stangret
2013-Mar-12 07:28 UTC
[flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite
Seems time is going to be a constraint for me in the coming week, but I'll try and get more of these out to you as fast as I can get them written and tested. Keeping the patches in a separate branch for now seems like a good idea to me. Attached is a patch for 'test_streams.sh' On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo <mle+la at mega-nerd.com>wrote:> Jaren Stangret wrote: > > > Attached are only three patches (each patch is for a different test > > script). If everyone is happy with these three patches, I'll continue > and > > rework the rest of the scripts. > > These look good so far. I've commited them to a branch. When I > get the rest I'll test them thoroughly as a batch. > > Erik > -- > ---------------------------------------------------------------------- > Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/74d38633/attachment-0001.htm -------------- next part -------------- A non-text attachment was scrubbed... Name: test_streams.sh.patch Type: application/octet-stream Size: 23689 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/74d38633/attachment-0001.obj