Johnny Rosenberg wrote:> Maybe a stupid question, but I was born stupid and I have walked that > path ever since, so: Is there a changelog?The only changelog is the git changelog. I will be writing a real changelog to go in the actual release tarball before the official release. The git changelog is available here: https://git.xiph.org/?p=flac.git;a=summary or in any git clone of this repo. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Visual Studio files (which don't use config.h, but define various things in the project settings) are compiling with the wrong FLAC version string (1.2.0 or 1.2.1) I've attached the patch. Maintaining Visual Studio project files in a cross-platform open-source project tends to be a pain unless one of the principal developers is using it on a daily basis (as I know you've experienced with libsndfile, Erik). -Ben Allison> Johnny Rosenberg wrote: > >> Maybe a stupid question, but I was born stupid and I have walked that >> path ever since, so: Is there a changelog? > > The only changelog is the git changelog. I will be writing a real > changelog to go in the actual release tarball before the official > release. > > The git changelog is available here: > > https://git.xiph.org/?p=flac.git;a=summary > > or in any git clone of this repo. > > Erik > -- > ---------------------------------------------------------------------- > Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev >-------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-update-VERSION-string-to-1.3.0-in-Visual-Studio-proj.patch Type: application/octet-stream Size: 7234 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130303/24f34125/attachment.obj
Ben Allison wrote:> Visual Studio files (which don't use config.h, but define various things > in the project settings) are compiling with the wrong FLAC version string > (1.2.0 or 1.2.1)Is there really no other way to set the version string?> I've attached the patch.Thanks. I'm wondering if it really should be 1.3.0 and not 1.3.0pre1 which is more accurate at least for now.> Maintaining Visual Studio project files in a cross-platform open-sourceQuite honestly I'm a little surprised it worked at all :-).> project tends to be a pain unless one of the principal developers is using > it on a daily basis (as I know you've experienced with libsndfile, Erik).Yes, painfully aware of this. I'll be relying on others to keep the VS project files up-to-date. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
There's a more few issues for compiling on MSVC. I put together a patch. Here's a quick rundown: * must use __inline keyword with static inline functions (bitmath.h) * change instances of uint32_t in bitwriter.c to FLAC__uint32 * functions marked inline cannot be used within another C file (e.g. FLAC__bitreader_get_input_bits_unconsumed produces the linker error "error LNK2001: unresolved external symbol _FLAC__bitreader_get_input_bits_unconsumed"). This change has performance implications! I'd like someone to review this and possibly come up with a better solution.> Johnny Rosenberg wrote: > >> Maybe a stupid question, but I was born stupid and I have walked that >> path ever since, so: Is there a changelog? > > The only changelog is the git changelog. I will be writing a real > changelog to go in the actual release tarball before the official > release. > > The git changelog is available here: > > https://git.xiph.org/?p=flac.git;a=summary > > or in any git clone of this repo. > > Erik > -- > ---------------------------------------------------------------------- > Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > flac-dev mailing list > flac-dev at xiph.org > http://lists.xiph.org/mailman/listinfo/flac-dev >-------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-MSVC-compatibility-fixes.patch Type: application/octet-stream Size: 12394 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130303/cedbbf2d/attachment.obj
Ben Allison wrote:> There's a more few issues for compiling on MSVC. I put together a patch. > > Here's a quick rundown: > * must use __inline keyword with static inline functions (bitmath.h)If you include "share/compath.h" you will get a inline #defined as __inline when _MSC_VER is defined. I'd prefer a single diffinition of that in one place and one place only.> * change instances of uint32_t in bitwriter.c to FLAC__uint32Can we include <inttypes.h> to fix this instead?> * functions marked inline cannot be used within another C file (e.g. > FLAC__bitreader_get_input_bits_unconsumed produces the linker error "error > LNK2001: unresolved external symbol > _FLAC__bitreader_get_input_bits_unconsumed"). This change has performance > implications! I'd like someone to review this and possibly come up with a > better solution.The solution there is to move the function definition to the header file as a static inline function static inline unsigned FLAC__bitreader_get_input_bits_unconsumed(const FLAC__BitReader *br) { return (br->words-br->consumed_words)*FLAC__BITS_PER_WORD + br->bytes*8 - br->consumed_bits; } Can you please try that and line me know if it works in MSVC? I know it works for GCC and Clang as its required for C99. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Ben Allison wrote:> Visual Studio files (which don't use config.h, but define various things > in the project settings) are compiling with the wrong FLAC version string > (1.2.0 or 1.2.1) > > I've attached the patch.Ben, I'll apply this patch when all the other issues are sorted out. Thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/