On 11/14/2011 18:01, JonY wrote:> On 11/10/2011 19:22, JonY wrote: >> On 11/10/2011 18:39, Erik de Castro Lopo wrote: >>> >>> I'm subscribed to the list (and I set my reply-to to the list). >>> Please do not CC me. >>> >>> JonY wrote: >>> >>>> Its probably on one of the sf tracker somewhere, I can't seem to find it >>>> anymore. It wasn't anything complicated, so I should be able to redo it >>>> quickly. >>> >>> I'm a Linux guy. I do not have easy access to a windows machine >>> and don't have the time or patience to maintain one. >>> >>> For windows stuff I'll be relying on others to provide and test >>> patches. >>> >>> Erik >> >> Alright, here's a quick fix, although it is more ugly than I remembered. >> >> Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h >> where available, and falls back to I64 on MSVC and then ll for others, >> all format warnings suppressed. >> >> Tested on MinGW. >> >> Sven-Hendrik, or any other mingw guys around, do you mind testing the >> patch too? Patch based on git master from >> https://git.xiph.org/mirrors/flac.git. >> > > Ifdef changes now consolidated into a single file.Ping, no comments? I noticed some more ifdeferies around that needs consolidating and warnings that need suppressing, that can go into a separate patch. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20111115/20c16d81/attachment.pgp
Erik de Castro Lopo
2011-Nov-15 19:20 UTC
[Flac-dev] Git branch with compiling fixes for win32
JonY wrote:> On 11/14/2011 18:01, JonY wrote: > > On 11/10/2011 19:22, JonY wrote: > >> On 11/10/2011 18:39, Erik de Castro Lopo wrote: > >>> > >>> I'm subscribed to the list (and I set my reply-to to the list). > >>> Please do not CC me. > >>> > >>> JonY wrote: > >>> > >>>> Its probably on one of the sf tracker somewhere, I can't seem to find it > >>>> anymore. It wasn't anything complicated, so I should be able to redo it > >>>> quickly. > >>> > >>> I'm a Linux guy. I do not have easy access to a windows machine > >>> and don't have the time or patience to maintain one. > >>> > >>> For windows stuff I'll be relying on others to provide and test > >>> patches. > >>> > >>> Erik > >> > >> Alright, here's a quick fix, although it is more ugly than I remembered. > >> > >> Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h > >> where available, and falls back to I64 on MSVC and then ll for others, > >> all format warnings suppressed. > >> > >> Tested on MinGW. > >> > >> Sven-Hendrik, or any other mingw guys around, do you mind testing the > >> patch too? Patch based on git master from > >> https://git.xiph.org/mirrors/flac.git. > >> > > > > Ifdef changes now consolidated into a single file. > > Ping, no comments? > > I noticed some more ifdeferies around that needs consolidating and > warnings that need suppressing, that can go into a separate patch.Sorry, I got hit by the Gnome3 catastrophe of 2011 and I'm still trying to make my machine usable. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 11/16/2011 03:20, Erik de Castro Lopo wrote:> JonY wrote: > >> On 11/14/2011 18:01, JonY wrote: >>> On 11/10/2011 19:22, JonY wrote: >>>> On 11/10/2011 18:39, Erik de Castro Lopo wrote: >>>>> >>>>> I'm subscribed to the list (and I set my reply-to to the list). >>>>> Please do not CC me. >>>>> >>>>> JonY wrote: >>>>> >>>>>> Its probably on one of the sf tracker somewhere, I can't seem to find it >>>>>> anymore. It wasn't anything complicated, so I should be able to redo it >>>>>> quickly. >>>>> >>>>> I'm a Linux guy. I do not have easy access to a windows machine >>>>> and don't have the time or patience to maintain one. >>>>> >>>>> For windows stuff I'll be relying on others to provide and test >>>>> patches. >>>>> >>>>> Erik >>>> >>>> Alright, here's a quick fix, although it is more ugly than I remembered. >>>> >>>> Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h >>>> where available, and falls back to I64 on MSVC and then ll for others, >>>> all format warnings suppressed. >>>> >>>> Tested on MinGW. >>>> >>>> Sven-Hendrik, or any other mingw guys around, do you mind testing the >>>> patch too? Patch based on git master from >>>> https://git.xiph.org/mirrors/flac.git. >>>> >>> >>> Ifdef changes now consolidated into a single file. >> >> Ping, no comments? >> >> I noticed some more ifdeferies around that needs consolidating and >> warnings that need suppressing, that can go into a separate patch. > > Sorry, I got hit by the Gnome3 catastrophe of 2011 and I'm still trying > to make my machine usable. > > ErikWow ok, haven't touched it since the gnone2 days, it was pretty decent back then. I'll come back later then. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20111116/f89deee0/attachment.pgp