Hey Judofyr! Fix this! When someone sets a cookie using @cookies.something = ''data'' it should be set with the path going to the camping app''s root, not with no path, otherwise only that controller with the same parameters will ever see the cookie again! Please change this code:> @cookies.each do |k, v| > @response.set_cookie(k, v) if o[k] != v > endto:> @cookies.each do |k, v| > @response.set_cookie(k, :value => v, :path => self/"/") if o[k] != v > endWhich should unbreak it, but cookie sessions will still remain broken so long as you keep using the longer weird set_cookie syntax in there without a path set. Please change it back to @cookie.stuff = "things". Againy, judofyr, now I find out in the trunk, still, you have a 15 minute timeout. When I said 10 minutes wasn''t enough I didn''t mean ''so bump it up to 15''. Please get rid of this and just use plain old untimed ''session cookies''. If you insist on having state_timeout functionality ? which I strongly feel is something a user could easily implement if they wanted it and beyond the scope of what should come with camping ? please default it to ''nil'' and change the logic to not be setting those timeout cookies when it is nil. We''re not Rails, we don''t need to build in every bit of functionality any user could ever want. We can provide timed sessions on the wiki. Well, at least we could if there was any way to make a new page on the wiki, which seems to be currently disabled. it looks like this:> def service(*a) > @state = Camping::H[] if @cookies.timeout < (Time.now - 1.hour); > @cookies.timeout = Time.now.to_i; super(*a) > endAnd, one more thing: I thought the cookie thing had been fixed now, but apparently the cookie setting logic is still happening in service(*a), making the cookies hash useless inside of service wrappers. The stuff in service(*a) should be moved out to call(...), outside of the services chain. It''s too weird to have to use weird rack api''s to do things in a service but have to use familiar simple camping inside of the camping app and before you call ''super()''. the inner most service should just do:> @body = (catch(:halt){send(@request.request_method.downcase, *a)} || > @body).to_sThen @body should be used and @headers and @status and @cookies should be all done in call() to do all the stuff currently being done in the service. Then we can live in a happy world where services really do work as ''before'' and ''after'' style methods and we don''t have to code to rack api''s half the time to make it work in ways which really cannot be understood without reading the camping source code. As is happening now, these api''s might be replaced entirely with some other thingo in the future if rack is superseded and break it all, not to mention that rack''s api''s are a lot less fun to code to than camping''s. If someone wants to tell me how git works, I''ll be happy to patch these problems myself, provided it isn''t a stressful or excessively difficult thing to do... My username on there is Bluebie. I have no idea how to use it. ? Blueberry the fictional pony -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://rubyforge.org/pipermail/camping-list/attachments/20080606/ea54149a/attachment-0001.html>
On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote:> If someone wants to tell me how git works, I''ll be happy to patch these > problems myself, provided it isn''t a stressful or excessively difficult > thing to do... My username on there is Bluebie. I have no idea how to use > it.Basically what you need to do is fork the project, add your changes, commit, and send me a pull request. The "pull request" is just a message that you have some changes to pick up. It''s like putting up the little flag on your mailbox to tell the mailman to stop by. First off, go here: http://github.com/why/camping/tree/master. And click the "fork" button.>From there, you''ll need to do the rest from a console:$ git clone git at github.com:Bluebie/camping.git $ cd camping # ... make your changes ... $ git commit -a # ... saves your changes ... $ git push # ... sends your changes to github ... And then, you can just send me a pull request. Go to your camping page: http://github.com/Bluebie/camping/tree/master. Click on "pull request" and explain the change. You''re going to love it. _why
now it''s in vim and I don''t know what to do and it wont let me quit and wont save... On 06/06/2008, at 11:35 AM, _why wrote:> On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote: >> If someone wants to tell me how git works, I''ll be happy to patch >> these >> problems myself, provided it isn''t a stressful or excessively >> difficult >> thing to do... My username on there is Bluebie. I have no idea how >> to use >> it. > > Basically what you need to do is fork the project, add your changes, > commit, and send me a pull request. The "pull request" is just a > message that you have some changes to pick up. It''s like putting up > the little flag on your mailbox to tell the mailman to stop by. > > First off, go here: http://github.com/why/camping/tree/master. > And click the "fork" button. > >> From there, you''ll need to do the rest from a console: > > $ git clone git at github.com:Bluebie/camping.git > $ cd camping > # ... make your changes ... > > $ git commit -a > # ... saves your changes ... > > $ git push > # ... sends your changes to github ... > > And then, you can just send me a pull request. Go to your camping > page: http://github.com/Bluebie/camping/tree/master. Click on "pull > request" and explain the change. > > You''re going to love it. > > _why > _______________________________________________ > Camping-list mailing list > Camping-list at rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list
I did some vimtutor and put some text in the thing and then :wq to save it and then it says:> fatal: There was a problem with the editor vi.A fantastic descriptive error if ever I did see one. can someone tell me how the heck to make vim go? Or better yet how to hack git to use TextMate or Coda instead? On 06/06/2008, at 11:54 AM, Bluebie, Jenna wrote:> now it''s in vim and I don''t know what to do and it wont let me quit > and wont save... > On 06/06/2008, at 11:35 AM, _why wrote: > >> On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote: >>> If someone wants to tell me how git works, I''ll be happy to patch >>> these >>> problems myself, provided it isn''t a stressful or excessively >>> difficult >>> thing to do... My username on there is Bluebie. I have no idea how >>> to use >>> it. >> >> Basically what you need to do is fork the project, add your changes, >> commit, and send me a pull request. The "pull request" is just a >> message that you have some changes to pick up. It''s like putting up >> the little flag on your mailbox to tell the mailman to stop by. >> >> First off, go here: http://github.com/why/camping/tree/master. >> And click the "fork" button. >> >>> From there, you''ll need to do the rest from a console: >> >> $ git clone git at github.com:Bluebie/camping.git >> $ cd camping >> # ... make your changes ... >> >> $ git commit -a >> # ... saves your changes ... >> >> $ git push >> # ... sends your changes to github ... >> >> And then, you can just send me a pull request. Go to your camping >> page: http://github.com/Bluebie/camping/tree/master. Click on "pull >> request" and explain the change. >> >> You''re going to love it. >> >> _why >> _______________________________________________ >> Camping-list mailing list >> Camping-list at rubyforge.org >> http://rubyforge.org/mailman/listinfo/camping-list > > _______________________________________________ > Camping-list mailing list > Camping-list at rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list
How did you end up in vim? You don''t need to use any particular editor, edit the files from the repository any way you want. You don''t actually have to make all your changes from the command line. -- Eric On Thu, Jun 5, 2008 at 10:07 PM, Bluebie, Jenna <blueberry at creativepony.com> wrote:> I did some vimtutor and put some text in the thing and then :wq to save it > and then it says: > >> fatal: There was a problem with the editor vi. > > > A fantastic descriptive error if ever I did see one. > > can someone tell me how the heck to make vim go? Or better yet how to hack > git to use TextMate or Coda instead? > > > On 06/06/2008, at 11:54 AM, Bluebie, Jenna wrote: > >> now it''s in vim and I don''t know what to do and it wont let me quit and >> wont save... >> On 06/06/2008, at 11:35 AM, _why wrote: >> >>> On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote: >>>> >>>> If someone wants to tell me how git works, I''ll be happy to patch these >>>> problems myself, provided it isn''t a stressful or excessively difficult >>>> thing to do... My username on there is Bluebie. I have no idea how to >>>> use >>>> it. >>> >>> Basically what you need to do is fork the project, add your changes, >>> commit, and send me a pull request. The "pull request" is just a >>> message that you have some changes to pick up. It''s like putting up >>> the little flag on your mailbox to tell the mailman to stop by. >>> >>> First off, go here: http://github.com/why/camping/tree/master. >>> And click the "fork" button. >>> >>>> From there, you''ll need to do the rest from a console: >>> >>> $ git clone git at github.com:Bluebie/camping.git >>> $ cd camping >>> # ... make your changes ... >>> >>> $ git commit -a >>> # ... saves your changes ... >>> >>> $ git push >>> # ... sends your changes to github ... >>> >>> And then, you can just send me a pull request. Go to your camping >>> page: http://github.com/Bluebie/camping/tree/master. Click on "pull >>> request" and explain the change. >>> >>> You''re going to love it. >>> >>> _why >>> _______________________________________________ >>> Camping-list mailing list >>> Camping-list at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/camping-list >> >> _______________________________________________ >> Camping-list mailing list >> Camping-list at rubyforge.org >> http://rubyforge.org/mailman/listinfo/camping-list > > _______________________________________________ > Camping-list mailing list > Camping-list at rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list >
Ooh I figured it out! On 06/06/2008, at 12:07 PM, Bluebie, Jenna wrote:> I did some vimtutor and put some text in the thing and then :wq to > save it and then it says: > >> fatal: There was a problem with the editor vi. > > > A fantastic descriptive error if ever I did see one. > > can someone tell me how the heck to make vim go? Or better yet how > to hack git to use TextMate or Coda instead? > > > On 06/06/2008, at 11:54 AM, Bluebie, Jenna wrote: > >> now it''s in vim and I don''t know what to do and it wont let me quit >> and wont save... >> On 06/06/2008, at 11:35 AM, _why wrote: >> >>> On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote: >>>> If someone wants to tell me how git works, I''ll be happy to patch >>>> these >>>> problems myself, provided it isn''t a stressful or excessively >>>> difficult >>>> thing to do... My username on there is Bluebie. I have no idea >>>> how to use >>>> it. >>> >>> Basically what you need to do is fork the project, add your changes, >>> commit, and send me a pull request. The "pull request" is just a >>> message that you have some changes to pick up. It''s like putting up >>> the little flag on your mailbox to tell the mailman to stop by. >>> >>> First off, go here: http://github.com/why/camping/tree/master. >>> And click the "fork" button. >>> >>>> From there, you''ll need to do the rest from a console: >>> >>> $ git clone git at github.com:Bluebie/camping.git >>> $ cd camping >>> # ... make your changes ... >>> >>> $ git commit -a >>> # ... saves your changes ... >>> >>> $ git push >>> # ... sends your changes to github ... >>> >>> And then, you can just send me a pull request. Go to your camping >>> page: http://github.com/Bluebie/camping/tree/master. Click on "pull >>> request" and explain the change. >>> >>> You''re going to love it. >>> >>> _why >>> _______________________________________________ >>> Camping-list mailing list >>> Camping-list at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/camping-list >> >> _______________________________________________ >> Camping-list mailing list >> Camping-list at rubyforge.org >> http://rubyforge.org/mailman/listinfo/camping-list > > _______________________________________________ > Camping-list mailing list > Camping-list at rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list
git forced me in to vim when I did git commit -a. Turns out that''s what it defaults to when EDITOR enviroment variable isn''t set. Now it is, all is well. On 06/06/2008, at 12:11 PM, Eric Mill wrote:> How did you end up in vim? You don''t need to use any particular > editor, edit the files from the repository any way you want. You > don''t actually have to make all your changes from the command line. > > -- Eric > > On Thu, Jun 5, 2008 at 10:07 PM, Bluebie, Jenna > <blueberry at creativepony.com> wrote: >> I did some vimtutor and put some text in the thing and then :wq to >> save it >> and then it says: >> >>> fatal: There was a problem with the editor vi. >> >> >> A fantastic descriptive error if ever I did see one. >> >> can someone tell me how the heck to make vim go? Or better yet how >> to hack >> git to use TextMate or Coda instead? >> >> >> On 06/06/2008, at 11:54 AM, Bluebie, Jenna wrote: >> >>> now it''s in vim and I don''t know what to do and it wont let me >>> quit and >>> wont save... >>> On 06/06/2008, at 11:35 AM, _why wrote: >>> >>>> On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote: >>>>> >>>>> If someone wants to tell me how git works, I''ll be happy to >>>>> patch these >>>>> problems myself, provided it isn''t a stressful or excessively >>>>> difficult >>>>> thing to do... My username on there is Bluebie. I have no idea >>>>> how to >>>>> use >>>>> it. >>>> >>>> Basically what you need to do is fork the project, add your >>>> changes, >>>> commit, and send me a pull request. The "pull request" is just a >>>> message that you have some changes to pick up. It''s like putting >>>> up >>>> the little flag on your mailbox to tell the mailman to stop by. >>>> >>>> First off, go here: http://github.com/why/camping/tree/master. >>>> And click the "fork" button. >>>> >>>>> From there, you''ll need to do the rest from a console: >>>> >>>> $ git clone git at github.com:Bluebie/camping.git >>>> $ cd camping >>>> # ... make your changes ... >>>> >>>> $ git commit -a >>>> # ... saves your changes ... >>>> >>>> $ git push >>>> # ... sends your changes to github ... >>>> >>>> And then, you can just send me a pull request. Go to your camping >>>> page: http://github.com/Bluebie/camping/tree/master. Click on >>>> "pull >>>> request" and explain the change. >>>> >>>> You''re going to love it. >>>> >>>> _why >>>> _______________________________________________ >>>> Camping-list mailing list >>>> Camping-list at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/camping-list >>> >>> _______________________________________________ >>> Camping-list mailing list >>> Camping-list at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/camping-list >> >> _______________________________________________ >> Camping-list mailing list >> Camping-list at rubyforge.org >> http://rubyforge.org/mailman/listinfo/camping-list >> > _______________________________________________ > Camping-list mailing list > Camping-list at rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list
Use the -m switch -- An?bal On Fri, Jun 6, 2008 at 9:42 PM, Bluebie, Jenna <blueberry at creativepony.com> wrote:> git forced me in to vim when I did git commit -a. Turns out that''s what it > defaults to when EDITOR enviroment variable isn''t set. Now it is, all is > well. > > > On 06/06/2008, at 12:11 PM, Eric Mill wrote: > >> How did you end up in vim? You don''t need to use any particular >> editor, edit the files from the repository any way you want. You >> don''t actually have to make all your changes from the command line. >> >> -- Eric >> >> On Thu, Jun 5, 2008 at 10:07 PM, Bluebie, Jenna >> <blueberry at creativepony.com> wrote: >>> >>> I did some vimtutor and put some text in the thing and then :wq to save >>> it >>> and then it says: >>> >>>> fatal: There was a problem with the editor vi. >>> >>> >>> A fantastic descriptive error if ever I did see one. >>> >>> can someone tell me how the heck to make vim go? Or better yet how to >>> hack >>> git to use TextMate or Coda instead? >>> >>> >>> On 06/06/2008, at 11:54 AM, Bluebie, Jenna wrote: >>> >>>> now it''s in vim and I don''t know what to do and it wont let me quit and >>>> wont save... >>>> On 06/06/2008, at 11:35 AM, _why wrote: >>>> >>>>> On Fri, Jun 06, 2008 at 11:18:22AM +1000, Bluebie, Jenna wrote: >>>>>> >>>>>> If someone wants to tell me how git works, I''ll be happy to patch >>>>>> these >>>>>> problems myself, provided it isn''t a stressful or excessively >>>>>> difficult >>>>>> thing to do... My username on there is Bluebie. I have no idea how to >>>>>> use >>>>>> it. >>>>> >>>>> Basically what you need to do is fork the project, add your changes, >>>>> commit, and send me a pull request. The "pull request" is just a >>>>> message that you have some changes to pick up. It''s like putting up >>>>> the little flag on your mailbox to tell the mailman to stop by. >>>>> >>>>> First off, go here: http://github.com/why/camping/tree/master. >>>>> And click the "fork" button. >>>>> >>>>>> From there, you''ll need to do the rest from a console: >>>>> >>>>> $ git clone git at github.com:Bluebie/camping.git >>>>> $ cd camping >>>>> # ... make your changes ... >>>>> >>>>> $ git commit -a >>>>> # ... saves your changes ... >>>>> >>>>> $ git push >>>>> # ... sends your changes to github ... >>>>> >>>>> And then, you can just send me a pull request. Go to your camping >>>>> page: http://github.com/Bluebie/camping/tree/master. Click on "pull >>>>> request" and explain the change. >>>>> >>>>> You''re going to love it. >>>>> >>>>> _why >>>>> _______________________________________________ >>>>> Camping-list mailing list >>>>> Camping-list at rubyforge.org >>>>> http://rubyforge.org/mailman/listinfo/camping-list >>>> >>>> _______________________________________________ >>>> Camping-list mailing list >>>> Camping-list at rubyforge.org >>>> http://rubyforge.org/mailman/listinfo/camping-list >>> >>> _______________________________________________ >>> Camping-list mailing list >>> Camping-list at rubyforge.org >>> http://rubyforge.org/mailman/listinfo/camping-list >>> >> _______________________________________________ >> Camping-list mailing list >> Camping-list at rubyforge.org >> http://rubyforge.org/mailman/listinfo/camping-list > > _______________________________________________ > Camping-list mailing list > Camping-list at rubyforge.org > http://rubyforge.org/mailman/listinfo/camping-list >