Rashika Kheria
2013-Oct-30 21:42 UTC
[PATCH v2] btrfs: Replace multiple atomic_inc() with atomic_add()
This patch replaces multiple atomic_inc() with atomic_add() in
delayed-inode.c to reduce source code and have few instructions
for compilation.
Reviewed-by: Zach Brown <zab@redhat.com>
Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
---
This revision fixes the following issues of the previous revision-
Space in comment
fs/btrfs/delayed-inode.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index cbd9523..504a9b5 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -108,8 +108,8 @@ static struct btrfs_delayed_node
*btrfs_get_delayed_node(struct inode *inode)
return node;
}
btrfs_inode->delayed_node = node;
- atomic_inc(&node->refs); /* can be accessed */
- atomic_inc(&node->refs); /* cached in the inode */
+ /* can be accessed and cached in the inode */
+ atomic_add(2, &node->refs);
spin_unlock(&root->inode_lock);
return node;
}
@@ -138,8 +138,8 @@ again:
return ERR_PTR(-ENOMEM);
btrfs_init_delayed_node(node, root, ino);
- atomic_inc(&node->refs); /* cached in the btrfs inode */
- atomic_inc(&node->refs); /* can be accessed */
+ /* cached in the btrfs inode and can be accessed */
+ atomic_add(2, &node->refs);
ret = radix_tree_preload(GFP_NOFS & ~__GFP_HIGHMEM);
if (ret) {
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Josh Triplett
2013-Nov-02 16:59 UTC
Re: [OPW kernel] [PATCH v2] btrfs: Replace multiple atomic_inc() with atomic_add()
On Thu, Oct 31, 2013 at 03:12:42AM +0530, Rashika Kheria wrote:> This patch replaces multiple atomic_inc() with atomic_add() in > delayed-inode.c to reduce source code and have few instructions > for compilation. > > Reviewed-by: Zach Brown <zab@redhat.com> > Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>Reviewed-by: Josh Triplett <josh@joshtriplett.org>> > This revision fixes the following issues of the previous revision- > Space in comment > > fs/btrfs/delayed-inode.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c > index cbd9523..504a9b5 100644 > --- a/fs/btrfs/delayed-inode.c > +++ b/fs/btrfs/delayed-inode.c > @@ -108,8 +108,8 @@ static struct btrfs_delayed_node *btrfs_get_delayed_node(struct inode *inode) > return node; > } > btrfs_inode->delayed_node = node; > - atomic_inc(&node->refs); /* can be accessed */ > - atomic_inc(&node->refs); /* cached in the inode */ > + /* can be accessed and cached in the inode */ > + atomic_add(2, &node->refs); > spin_unlock(&root->inode_lock); > return node; > } > @@ -138,8 +138,8 @@ again: > return ERR_PTR(-ENOMEM); > btrfs_init_delayed_node(node, root, ino); > > - atomic_inc(&node->refs); /* cached in the btrfs inode */ > - atomic_inc(&node->refs); /* can be accessed */ > + /* cached in the btrfs inode and can be accessed */ > + atomic_add(2, &node->refs); > > ret = radix_tree_preload(GFP_NOFS & ~__GFP_HIGHMEM); > if (ret) { > -- > 1.7.9.5 > > -- > You received this message because you are subscribed to the Google Groups "opw-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to opw-kernel+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out.-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html