Filipe Brandenburger
2013-Jan-24 18:32 UTC
Please revert 2794ed0 (fix permissions of empty files not affected by umask)
Hi, Please revert commit 2794ed013b3551cbae887ea1b93c52aaacb7370d. That patch was meant to be added to btrfs_create and not to btrfs_mknod. (It was indeed later added to btrfs_create on commit 9185aa587b7425f8f4520da2e66792f5f3c2b815, so that''s already OK.) btrfs_mknod already has a call to btrfs_update_inode later in the code so I don''t think the duplicate is really needed at that point. Thanks! Filipe -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Josef Bacik
2013-Jan-24 18:42 UTC
Re: Please revert 2794ed0 (fix permissions of empty files not affected by umask)
On Thu, Jan 24, 2013 at 11:32:17AM -0700, Filipe Brandenburger wrote:> Hi, > > Please revert commit 2794ed013b3551cbae887ea1b93c52aaacb7370d. That > patch was meant to be added to btrfs_create and not to btrfs_mknod. > > (It was indeed later added to btrfs_create on commit > 9185aa587b7425f8f4520da2e66792f5f3c2b815, so that''s already OK.) > > btrfs_mknod already has a call to btrfs_update_inode later in the code > so I don''t think the duplicate is really needed at that point. >Hrm sorry I''ll fix that in btrfs-next, I probably screwed this up when merging the patch, I remember having to manually apply this one. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html