On Fri, 5 Oct 2012 16:55:00 -0400, Josef Bacik wrote:> Alloc_dummy_extent_buffer will not free the first page in the eb array if
we
> fail to allocate a page, fix this. Thanks,
>
> Reported-by: David Sterba <dave@jikos.cz>
> Signed-off-by: Josef Bacik <jbacik@fusionio.com>
> ---
> fs/btrfs/extent_io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index 7dc69b3..64dc93f 100644
> --- a/fs/btrfs/extent_io.c
> +++ b/fs/btrfs/extent_io.c
> @@ -4104,7 +4104,7 @@ struct extent_buffer *alloc_dummy_extent_buffer(u64
start, unsigned long len)
>
> return eb;
> err:
> - for (i--; i > 0; i--)
> + for (i--; i >= 0; i--)
> __free_page(eb->pages[i]);
> __free_extent_buffer(eb);
> return NULL;
>
gcc says "warning: comparison of unsigned expression >= 0 is always
true" because i is an unsigned long. And gcc is right this time.
Reviewed-And-Rejected-By: gcc
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs"
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html