Fengguang Wu
2012-Aug-02 02:31 UTC
[josef-btrfs:master 9/11] fs/btrfs/transaction.c:1118:6: warning: ''parent'' may be used uninitialized in this function
Hi Miao, There are new compile warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master head: 8e1163044779e90662e96887cdd692c1594146ad commit: dd817e81e81bbb83b63317b169d0e57a5d7ae0e1 [9/11] Btrfs: fix error path in create_pending_snapshot() config: x86_64-randconfig-h031 (attached as .config) All error/warnings: fs/btrfs/transaction.c: In function ''create_pending_snapshot'': fs/btrfs/transaction.c:1118:6: warning: ''parent'' may be used uninitialized in this function [-Wmaybe-uninitialized] fs/btrfs/transaction.c:1119:19: warning: ''rsv'' may be used uninitialized in this function [-Wmaybe-uninitialized] vim +1118 fs/btrfs/transaction.c 1115 if (ret) 1116 goto abort_trans; 1117 fail:> 1118 dput(parent);1119 trans->block_rsv = rsv; 1120 no_free_objectid: 1121 kfree(new_root_item); --- 0-DAY kernel build testing backend Open Source Technology Centre Fengguang Wu <wfg@linux.intel.com> Intel Corporation
Miao Xie
2012-Aug-02 04:29 UTC
Re: [josef-btrfs:master 9/11] fs/btrfs/transaction.c:1118:6: warning: ''parent'' may be used uninitialized in this function
On Thu, 2 Aug 2012 10:31:23 +0800, Fengguang Wu wrote:> There are new compile warnings show up in > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master > head: 8e1163044779e90662e96887cdd692c1594146ad > commit: dd817e81e81bbb83b63317b169d0e57a5d7ae0e1 [9/11] Btrfs: fix error path in create_pending_snapshot() > config: x86_64-randconfig-h031 (attached as .config) > > All error/warnings: > > fs/btrfs/transaction.c: In function ''create_pending_snapshot'': > fs/btrfs/transaction.c:1118:6: warning: ''parent'' may be used uninitialized in this function [-Wmaybe-uninitialized] > fs/btrfs/transaction.c:1119:19: warning: ''rsv'' may be used uninitialized in this function [-Wmaybe-uninitialized] > > vim +1118 fs/btrfs/transaction.c > 1115 if (ret) > 1116 goto abort_trans; > 1117 fail: >> 1118 dput(parent); > 1119 trans->block_rsv = rsv; > 1120 no_free_objectid: > 1121 kfree(new_root_item);The patch I sent before is based on the v3.5.0, not Chris''s latest for-linus branch, so... I will send new patches to fix it. Thanks for your report. Miao> > --- > 0-DAY kernel build testing backend Open Source Technology Centre > Fengguang Wu <wfg@linux.intel.com> Intel Corporation >-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Josef Bacik
2012-Aug-02 12:07 UTC
Re: [josef-btrfs:master 9/11] fs/btrfs/transaction.c:1118:6: warning: ''parent'' may be used uninitialized in this function
On Wed, Aug 01, 2012 at 10:29:21PM -0600, Miao Xie wrote:> On Thu, 2 Aug 2012 10:31:23 +0800, Fengguang Wu wrote: > > There are new compile warnings show up in > > > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git master > > head: 8e1163044779e90662e96887cdd692c1594146ad > > commit: dd817e81e81bbb83b63317b169d0e57a5d7ae0e1 [9/11] Btrfs: fix error path in create_pending_snapshot() > > config: x86_64-randconfig-h031 (attached as .config) > > > > All error/warnings: > > > > fs/btrfs/transaction.c: In function ''create_pending_snapshot'': > > fs/btrfs/transaction.c:1118:6: warning: ''parent'' may be used uninitialized in this function [-Wmaybe-uninitialized] > > fs/btrfs/transaction.c:1119:19: warning: ''rsv'' may be used uninitialized in this function [-Wmaybe-uninitialized] > > > > vim +1118 fs/btrfs/transaction.c > > 1115 if (ret) > > 1116 goto abort_trans; > > 1117 fail: > >> 1118 dput(parent); > > 1119 trans->block_rsv = rsv; > > 1120 no_free_objectid: > > 1121 kfree(new_root_item); > > The patch I sent before is based on the v3.5.0, not Chris''s latest for-linus branch, so... > > I will send new patches to fix it. Thanks for your report. >I''ve pulled these patches, Dave still has concerns about corruption. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html