Mitch Harder
2012-Jul-28 22:20 UTC
[PATCH 0/1] Btrfs: Explicitly include vmalloc.h in send.c
When compiling without SMP and generic x86_64, I encountered the following errors due to vmalloc.h not being implicitly included: CC fs/btrfs/send.o fs/btrfs/send.c: In function ‘fs_path_free’: fs/btrfs/send.c:185:4: error: implicit declaration of function ‘vfree’ fs/btrfs/send.c: In function ‘fs_path_ensure_buf’: fs/btrfs/send.c:215:4: error: implicit declaration of function ‘vmalloc’ fs/btrfs/send.c:215:12: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c:225:12: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c:233:13: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c: In function ‘iterate_dir_item’: fs/btrfs/send.c:900:10: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c:909:11: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c: In function ‘btrfs_ioctl_send’: fs/btrfs/send.c:4462:17: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c:4468:17: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c:4474:2: error: implicit declaration of function ‘vzalloc’ fs/btrfs/send.c:4474:20: warning: assignment makes pointer from integer without a cast fs/btrfs/send.c:4482:21: warning: assignment makes pointer from integer without a cast make[2]: *** [fs/btrfs/send.o] Error 1 make[1]: *** [fs/btrfs] Error 2 If it makes sense, please feel free to include this minor change in with other send/receive fixes. Mitch Harder (1): Btrfs: Explicitly include vmalloc.h in send.c fs/btrfs/send.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) -- 1.7.8.6 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Mitch Harder
2012-Jul-28 22:20 UTC
[PATCH 1/1] Btrfs: Explicitly include vmalloc.h in send.c
Certain architectures or platforms or combinations of CONFIG options require an explicit #include <linux/vmalloc.h>. Signed-off-by: Mitch Harder <mitch.harder@sabayonlinux.org> --- fs/btrfs/send.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c index bf232c8..118e76d 100644 --- a/fs/btrfs/send.c +++ b/fs/btrfs/send.c @@ -25,6 +25,7 @@ #include <linux/posix_acl_xattr.h> #include <linux/radix-tree.h> #include <linux/crc32c.h> +#include <linux/vmalloc.h> #include "send.h" #include "backref.h" -- 1.7.8.6 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Josef Bacik
2012-Jul-30 13:46 UTC
Re: [PATCH 0/1] Btrfs: Explicitly include vmalloc.h in send.c
On Sat, Jul 28, 2012 at 04:20:02PM -0600, Mitch Harder wrote:> When compiling without SMP and generic x86_64, I encountered the > following errors due to vmalloc.h not being implicitly included: > > CC fs/btrfs/send.o > fs/btrfs/send.c: In function ‘fs_path_free’: > fs/btrfs/send.c:185:4: error: implicit declaration of function ‘vfree’ > fs/btrfs/send.c: In function ‘fs_path_ensure_buf’: > fs/btrfs/send.c:215:4: error: implicit declaration of function ‘vmalloc’ > fs/btrfs/send.c:215:12: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c:225:12: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c:233:13: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c: In function ‘iterate_dir_item’: > fs/btrfs/send.c:900:10: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c:909:11: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c: In function ‘btrfs_ioctl_send’: > fs/btrfs/send.c:4462:17: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c:4468:17: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c:4474:2: error: implicit declaration of function ‘vzalloc’ > fs/btrfs/send.c:4474:20: warning: assignment makes pointer from integer without a cast > fs/btrfs/send.c:4482:21: warning: assignment makes pointer from integer without a cast > make[2]: *** [fs/btrfs/send.o] Error 1 > make[1]: *** [fs/btrfs] Error 2 > > If it makes sense, please feel free to include this minor change in with > other send/receive fixes. > > Mitch Harder (1): > Btrfs: Explicitly include vmalloc.h in send.c > > fs/btrfs/send.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) >Already fixed by the linux-next maintainer. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html